Author: Jonas Devlieghere Date: 2024-07-03T09:03:47-07:00 New Revision: f057130b169fe551b1fec6633fadba26ef19bcdd
URL: https://github.com/llvm/llvm-project/commit/f057130b169fe551b1fec6633fadba26ef19bcdd DIFF: https://github.com/llvm/llvm-project/commit/f057130b169fe551b1fec6633fadba26ef19bcdd.diff LOG: [lldb] Remove commented-out Platform::FindPlugin (NFC) Added: Modified: lldb/include/lldb/Target/Platform.h lldb/source/Target/Platform.cpp Removed: ################################################################################ diff --git a/lldb/include/lldb/Target/Platform.h b/lldb/include/lldb/Target/Platform.h index 48988b838f67a..5ed2fc33356d9 100644 --- a/lldb/include/lldb/Target/Platform.h +++ b/lldb/include/lldb/Target/Platform.h @@ -108,21 +108,6 @@ class Platform : public PluginInterface { static ArchSpec GetAugmentedArchSpec(Platform *platform, llvm::StringRef triple); - /// Find a platform plugin for a given process. - /// - /// Scans the installed Platform plug-ins and tries to find an instance that - /// can be used for \a process - /// - /// \param[in] process - /// The process for which to try and locate a platform - /// plug-in instance. - /// - /// \param[in] plugin_name - /// An optional name of a specific platform plug-in that - /// should be used. If nullptr, pick the best plug-in. - // static lldb::PlatformSP - // FindPlugin (Process *process, ConstString plugin_name); - /// Set the target's executable based off of the existing architecture /// information in \a target given a path to an executable \a exe_file. /// diff --git a/lldb/source/Target/Platform.cpp b/lldb/source/Target/Platform.cpp index b3116545b91d1..c06abd3070f31 100644 --- a/lldb/source/Target/Platform.cpp +++ b/lldb/source/Target/Platform.cpp @@ -161,40 +161,6 @@ Platform::LocateExecutableScriptingResources(Target *target, Module &module, return FileSpecList(); } -// PlatformSP -// Platform::FindPlugin (Process *process, ConstString plugin_name) -//{ -// PlatformCreateInstance create_callback = nullptr; -// if (plugin_name) -// { -// create_callback = -// PluginManager::GetPlatformCreateCallbackForPluginName (plugin_name); -// if (create_callback) -// { -// ArchSpec arch; -// if (process) -// { -// arch = process->GetTarget().GetArchitecture(); -// } -// PlatformSP platform_sp(create_callback(process, &arch)); -// if (platform_sp) -// return platform_sp; -// } -// } -// else -// { -// for (uint32_t idx = 0; (create_callback = -// PluginManager::GetPlatformCreateCallbackAtIndex(idx)) != nullptr; -// ++idx) -// { -// PlatformSP platform_sp(create_callback(process, nullptr)); -// if (platform_sp) -// return platform_sp; -// } -// } -// return PlatformSP(); -//} - Status Platform::GetSharedModule( const ModuleSpec &module_spec, Process *process, ModuleSP &module_sp, const FileSpecList *module_search_paths_ptr, _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
