labath wrote:

> LGTM.
> 
> As a nice to have, maybe add a short explanation to the first mutex 
> explaining that these operations are only allowed between thread lists 
> belonging to the same process. Your current comment makes it sound as if that 
> only applies _if_ the processes are the same, but per the assertion, the 
> requirement is stricter than that.
> 
> EDIT: Oh I see you had the comment in the header. That covers my concern, 
> though I'd still add the same thing to the assert to quickly diagnose the 
> issue if someone were to hit it.

Elaborated the assert comment as well.

https://github.com/llvm/llvm-project/pull/98293
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to