https://github.com/JDevlieghere requested changes to this pull request.

Please don't use environment variables to pass options to the `make` 
invocation. It makes it really hard to reproduce build failures because you 
can't just copy-paste the failing invocation to debug the build. I went through 
an effort to clean that up a few years ago. If there are other instances that 
do this then they slipped in without my knowledge. 

A similar problem applies to the `dotest.py` invocation and the 
`lldb-dotest.py` wrapper configured by CMake that a bunch of folks rely on. 

TL;DR: instead of an environment variable, please add this as an option to 
`dotest.py` and pass it explicitly as part of the `make` invocation in 
`builder.py`.

https://github.com/llvm/llvm-project/pull/100836
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to