================ @@ -0,0 +1,58 @@ +// REQUIRES: system-linux, native ---------------- clayborg wrote:
Adding support for memory ELF files is my primary concern with this patch as you know. Testing that in memory ELF files work as well as they can and that we can find the DT_DEBUG is the primary goal of this patch, so I would still like to concentrate on that. I have yet to run into an ELF file in the wild that doesn't have section headers, though I know they are possible. Testing I can load a ELF file from disk with no section headers is a whole other code path that introduces changes and time to this patch which I would rather not take on at this point if possible. Getting core files to be able to have a shared library list without having the main executable makes ELF core file actually useful now instead of being useless unless you get the correct executable. So although testing an on disk ELF file with no section headers is nice for testing, it can't replace the test I have written because we need this to test the in memory ELF files and testing the file itself is whole other code path that isn't needed. I will be happy to add support for on disk ELF files after this patch, but I would like to get the useful part of this patch checked in so we can get ELF core files to be useful with no executable. https://github.com/llvm/llvm-project/pull/101237 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
