ilovepi wrote:
We're seeing a failure in our CI after this patch, would you mind taking a look
and reverting if its going to take a while to fix?
Error:
```
FAILED:
tools/lldb/unittests/Process/elf-core/CMakeFiles/ProcessElfCoreTests.dir/ThreadElfCoreTest.cpp.o
/b/s/w/ir/x/w/rc/cxx-rbe47grlile/reclient-cxx-wrapper.sh
/b/s/w/ir/x/w/cipd/bin/clang++ --sysroot=/b/s/w/ir/x/w/cipd/linux
-DGTEST_HAS_RTTI=0 -DHAVE_ROUND -DLIBXML_STATIC -D_DEBUG -D_GLIBCXX_ASSERTIONS
-D_GNU_SOURCE -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS
-D__STDC_LIMIT_MACROS
-I/b/s/w/ir/x/w/llvm_build/tools/lldb/unittests/Process/elf-core
-I/b/s/w/ir/x/w/llvm-llvm-project/lldb/unittests/Process/elf-core
-I/b/s/w/ir/x/w/llvm-llvm-project/lldb/include
-I/b/s/w/ir/x/w/llvm_build/tools/lldb/include
-I/b/s/w/ir/x/w/rc/tensorflow-venv/store/python_venv-u3hh0hkn7c13sepmcfocq14vq0/contents/lib/python3.8/site-packages/tensorflow/include
-I/b/s/w/ir/x/w/llvm_build/include
-I/b/s/w/ir/x/w/llvm-llvm-project/llvm/include
-I/b/s/w/ir/x/w/lldb_install/python3/include/python3.11
-I/b/s/w/ir/x/w/llvm-llvm-project/llvm/../clang/include
-I/b/s/w/ir/x/w/llvm_build/tools/lldb/../clang/include
-I/b/s/w/ir/x/w/llvm-llvm-project/lldb/source
-I/b/s/w/ir/x/w/llvm-llvm-project/lldb/unittests
-I/b/s/w/ir/x/w/llvm-llvm-project/third-party/unittest/googletest/include
-I/b/s/w/ir/x/w/llvm-llvm-project/third-party/unittest/googlemock/include
-isystem /b/s/w/ir/x/w/libxml2_install_target/include/libxml2 -isystem
/b/s/w/ir/x/w/zlib_install_target/include -isystem
/b/s/w/ir/x/w/zstd_install/include -isystem
/b/s/w/ir/x/w/libedit_install/include -stdlib=libc++ -fPIC
-fno-semantic-interposition -fvisibility-inlines-hidden -Werror=date-time
-Werror=unguarded-availability-new -Wall -Wextra -Wno-unused-parameter
-Wwrite-strings -Wcast-qual -Wmissing-field-initializers -pedantic
-Wno-long-long -Wc++98-compat-extra-semi -Wimplicit-fallthrough
-Wcovered-switch-default -Wno-noexcept-type -Wnon-virtual-dtor
-Wdelete-non-virtual-dtor -Wsuggest-override -Wno-comment -Wstring-conversion
-Wmisleading-indentation -Wctad-maybe-unsupported -fdiagnostics-color
-ffunction-sections -fdata-sections -ffat-lto-objects
-ffile-prefix-map=/b/s/w/ir/x/w/llvm_build=../llvm-llvm-project
-ffile-prefix-map=/b/s/w/ir/x/w/llvm-llvm-project/= -no-canonical-prefixes
-Wno-deprecated-declarations -Wno-unknown-pragmas -Wno-strict-aliasing
-Wno-deprecated-register -Wno-vla-extension -O3 -DNDEBUG -std=c++17
-fvisibility=default -Wno-variadic-macros
-Wno-gnu-zero-variadic-macro-arguments -fno-exceptions -fno-unwind-tables
-fno-asynchronous-unwind-tables -fno-rtti -UNDEBUG -Wno-suggest-override -MD
-MT
tools/lldb/unittests/Process/elf-core/CMakeFiles/ProcessElfCoreTests.dir/ThreadElfCoreTest.cpp.o
-MF
tools/lldb/unittests/Process/elf-core/CMakeFiles/ProcessElfCoreTests.dir/ThreadElfCoreTest.cpp.o.d
-o
tools/lldb/unittests/Process/elf-core/CMakeFiles/ProcessElfCoreTests.dir/ThreadElfCoreTest.cpp.o
-c
/b/s/w/ir/x/w/llvm-llvm-project/lldb/unittests/Process/elf-core/ThreadElfCoreTest.cpp
/b/s/w/ir/x/w/llvm-llvm-project/lldb/unittests/Process/elf-core/ThreadElfCoreTest.cpp:94:56:
error: use of undeclared identifier 'gettid'
94 | std::make_shared<DummyThread>(*process_sp.get(), gettid());
| ^
/b/s/w/ir/x/w/llvm-llvm-project/lldb/unittests/Process/elf-core/ThreadElfCoreTest.cpp:170:57:
error: use of undeclared identifier 'gettid'
170 | ASSERT_EQ(prstatus_opt->pr_pid, static_cast<uint32_t>(gettid()));
| ^
/b/s/w/ir/x/w/llvm-llvm-project/lldb/unittests/Process/elf-core/ThreadElfCoreTest.cpp:173:64:
error: use of undeclared identifier 'gettid'
173 | ASSERT_EQ(prstatus_opt->pr_sid,
static_cast<uint32_t>(getsid(gettid())));
| ^
3 errors generated.
```
Bot:
https://ci.chromium.org/ui/p/fuchsia/builders/toolchain.ci/clang-linux-x64/b8739431848195463889/overview
Logs:
https://logs.chromium.org/logs/fuchsia/buildbucket/cr-buildbucket/8739431848195463889/+/u/lldb/test/stdout
https://github.com/llvm/llvm-project/pull/104109
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
