Eli Friedman <[email protected]> writes: > On Wed, Jul 7, 2010 at 11:24 AM, Stephen Wilson <[email protected]> wrote: >> >> Hi Eli, >> >> Eli Friedman <[email protected]> writes: >>> Magic "1" is bad; use ELFCLASS32 (which is in the LLVM ELF.h). >> >> OK. Updated local elf.h with the constant. Updating llvm's ELF.h so we >> can use it is on my todo list. >> >>> Can you make the diff for ObjectFileELF64.cpp on top of an "svn cp"? >>> It's difficult to review otherwise. >> >> Attached is an updated patch set attempting to minimize changes between >> the 32 and 64 bit versions, and two diffs comparing the original and new >> code. >> >> Minor style differences between the two is an attempt to remain within >> 80 columns, and a preference for function application/declaration in the >> form "foo()" instead of with a space "foo ()" (I see both styles used in >> the code base. If there is a preference and I made the wrong choice I >> will be happy to fix it). > > Your patch was committed. > > There appear to be some interesting enhancements/bug-fixes in the > ELF-64 code compared to the ELF-32 code; would you mind writing a > cleanup patch for the ELF-32 code?
Will do. It may take a day or two, depending on time. Take care, Steve _______________________________________________ lldb-dev mailing list [email protected] http://lists.cs.uiuc.edu/mailman/listinfo/lldb-dev
