Hello Marco ++ I think the break is due to that i had thought all uses of items in arpa/inet.h were already protected by #ifdef __APPLE__ when they were not. at least that part of your patch would obviously take care of that.
i'm not entirely certain about the name. the problem is not that unix style sockets are not supported, but that they aren't supported precisely in the same way. winsock, winsock2, and ws2tcpip headers on mingw support part but not all of the calls made herein, and even then, will support more or less based upon the version of windows being used. Let me try to take your patch and tweak it, and then also test the build on linux. Best Regards, ++ Kirk On 2011-Feb-9, at 4:25 PM, ext Marco Minutoli wrote: Hello, today trying to build lldb on Linux I got an error due to some missing header files caused by an ifdef. In the attachment you should find a little patch that fix the build problem (this time I hope in the right way ;) ). I don't know if mingw has those headers too so I haven't declared the macro for it in its Config.h. I was wondering if there is some introductory task I can work on. Do you have any suggestions? Best regards, Marco -- Marco Minutoli "If A is success in life, then A equals x plus y plus z. Work is x; y is play; and z is keeping your mouth shut." --A. Einstein
Index: include/lldb/Host/freebsd/Config.h =================================================================== --- include/lldb/Host/freebsd/Config.h (revision 125241) +++ include/lldb/Host/freebsd/Config.h (working copy) @@ -27,4 +27,6 @@ //#define LLDB_CONFIG_FCNTL_GETPATH_SUPPORTED 1 -#endif // #ifndef liblldb_Platform_Config_h_ \ No newline at end of file +#define LLDB_CONFIG_SUPPORTS_UNIX_SOCKET 1 + +#endif // #ifndef liblldb_Platform_Config_h_ Index: include/lldb/Host/linux/Config.h =================================================================== --- include/lldb/Host/linux/Config.h (revision 125241) +++ include/lldb/Host/linux/Config.h (working copy) @@ -27,4 +27,6 @@ //#define LLDB_CONFIG_FCNTL_GETPATH_SUPPORTED 1 +#define LLDB_CONFIG_SUPPORTS_UNIX_SOCKET 1 + #endif // #ifndef liblldb_Platform_Config_h_ Index: include/lldb/Host/macosx/Config.h =================================================================== --- include/lldb/Host/macosx/Config.h (revision 125241) +++ include/lldb/Host/macosx/Config.h (working copy) @@ -27,4 +27,6 @@ #define LLDB_CONFIG_FCNTL_GETPATH_SUPPORTED 1 +#define LLDB_CONFIG_SUPPORTS_UNIX_SOCKET 1 + #endif // #ifndef liblldb_Platform_Config_h_ Index: include/lldb/Host/mingw/Config.h =================================================================== --- include/lldb/Host/mingw/Config.h (revision 125241) +++ include/lldb/Host/mingw/Config.h (working copy) @@ -27,4 +27,6 @@ //#define LLDB_CONFIG_FCNTL_GETPATH_SUPPORTED 1 +//#define LLDB_CONFIG_SUPPORTS_UNIX_SOCKET 1 + #endif // #ifndef liblldb_Platform_Config_h_ Index: source/Core/ConnectionFileDescriptor.cpp =================================================================== --- source/Core/ConnectionFileDescriptor.cpp (revision 125241) +++ source/Core/ConnectionFileDescriptor.cpp (working copy) @@ -12,7 +12,9 @@ // C Includes #include <errno.h> #include <fcntl.h> -#ifdef __APPLE__ + +#include "lldb/Host/Config.h" +#ifdef LLDB_CONFIG_SUPPORTS_UNIX_SOCKET #include <arpa/inet.h> #include <netdb.h> #include <netinet/in.h> @@ -20,6 +22,7 @@ #include <sys/socket.h> #include <sys/un.h> #endif + #include <sys/types.h> #include <string.h> #include <stdlib.h>
++ kirk beitz : nokia : austin + san diego : [email protected] ++ |
_______________________________________________ lldb-dev mailing list [email protected] http://lists.cs.uiuc.edu/mailman/listinfo/lldb-dev
