The patch looks fine. The "%tid" seems like it shouldn't need to exist. If we just leave it off, then it should "do the right thing", which would mean to default to the standard way to display a thread ID. On Jul 30, 2013, at 9:33 AM, Michael Sartain <[email protected]> wrote:
> On Tue, Jul 30, 2013 at 6:53 AM, Ed Maste <[email protected]> wrote: > On 29 July 2013 22:13, Michael Sartain <[email protected]> wrote: > > > > Here is a patch that defaults thread ids to decimal for freebsd + linux, and > > also adds the ability to add print specifiers to process.id, thread.id, > > thread.protocol.id, thread.index, and line.number. Something like this: > > > > // Allow format specifiers: x|X|u with optional width > > specifiers. > > // {thread.id%x} ; hex > > // {thread.id%X} ; uppercase hex > > // {thread.id%u} ; unsigned decimal > > // {thread.id%8.8X} ; width.precision + specifier > > > > http://llvm-reviews.chandlerc.com/D1234 > > > > Please holler with any feedback. Thanks, > > -Mike > > Overall it looks fine to me. I think we'd ideally have a run-time > default, so that if you e.g. debug a Linux core on OS X you get > decimal TIDs, but that could be done later if it's awkward. > > I added a %tid specifier which seems to be a fairly clean way of getting > this. Default thread format looks like this now: > > #define DEFAULT_THREAD_FORMAT "thread #${thread.index}: tid = > ${thread.id%tid}"\ > "{, ${frame.pc}}"\ ... > > Let me know if this looks ok and I'll commit... > Thanks. > -Mike > _______________________________________________ > lldb-dev mailing list > [email protected] > http://lists.cs.uiuc.edu/mailman/listinfo/lldb-dev _______________________________________________ lldb-dev mailing list [email protected] http://lists.cs.uiuc.edu/mailman/listinfo/lldb-dev
