Looks fine. Please commit files separately for 1 2 and 3 with appropriate comments.
Greg On Jan 16, 2014, at 3:00 PM, Steve Pucci <[email protected]> wrote: > Here are some fixes (patch attached) to remove compile warnings with gcc > 4.8.2. Notes: > > 1. The change to Iterable.h with the template parameters is to avoid the gcc > warning -Wno-non-template-friend that friend declarations inside template > classes must be declared as templates: > http://stackoverflow.com/questions/4039817/friend-declaration-declares-a-non-template-function > > 2. The rename of Platform::GetFile (the three-argument version) to > GetFileWithUUID was suggested by gclayton as a way to silence gcc warnings; > the warning is emitted when there is an overloaded function in a base class > (Platform) for which a derived class redefines one of the overloads but not > the other (because doing so hides the other overload from users of the > derived class). By giving the two methods different names, the situation is > avoided. > > 3. Rest are simple adds of const in appropriate places to silence warnings > about casting away constness. > > - Steve > <patch-warnings.txt>_______________________________________________ > lldb-dev mailing list > [email protected] > http://lists.cs.uiuc.edu/mailman/listinfo/lldb-dev _______________________________________________ lldb-dev mailing list [email protected] http://lists.cs.uiuc.edu/mailman/listinfo/lldb-dev
