On 19 December 2017 at 18:06, Greg Clayton <clayb...@gmail.com> wrote: > > The crash hook is needed since ReportCrash on MacOS knows how to dig up a > crash log line for each shared library that is currently loaded in a process > when it generates a crash report. There are settings that we can enable to > enable allowing the expression that is being run to be logged: > > (lldb) settings set target.display-expression-in-crashlogs 1 > > These crash hooks, if we are talking about the host level call that sets the > crash log lines and not something else, have been invaluable over the years > so I would venture to say we don't want to take them out. Not sure if any > other system does anything with these. If Apple is the only one, we can > conditionally compile them in only for Apple targets if needed and use macro > to set them that does nothing on non Apple builds. > > Greg >
I wasn't familiar with that setting, but I think we are talking about something different here, as this is code that only runs as a part of test (test/testcases/crashinfo.c). The main reason I suggested removal is because it is bolted onto the test suite in quite a crude fashion. The right solution would be to generate the crashinfo.so as a part of the regular build (in which case we wouldn't have the current problem where the crashinfo hook fails in some configurations even though the rest of the lldb builds just fine). _______________________________________________ lldb-dev mailing list lldb-dev@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-dev
