Thanks Greg, I changed the title and abstract, please check it out. https://summerofcode.withgoogle.com/projects/#5427847301169152
Regards, Alexander Polyakov 2018-04-24 19:44 GMT+03:00 Greg Clayton <clayb...@gmail.com>: > > > On Apr 24, 2018, at 9:37 AM, Jim Ingham <jing...@apple.com> wrote: > > > On Apr 24, 2018, at 7:43 AM, Greg Clayton via lldb-dev < > lldb-dev@lists.llvm.org> wrote: > > Welcome Alexander! > > > Yes, welcome! > > > The title might be more stated as "Reimplement lldb-mi to correctly use > the SB API instead of using HandleCommand and regular expressions to parse > the command results" as it is already using the SB API, just not using it > anywhere close to correctly! > > I look forward to seeing the changes. > > A few things I ran into when playing with lldb-mi: > - file-exec or exec-file packet might come _after_ some breakpoints are > set. We should make sure we create a lldb::SBTarget right away and set the > breakpoints on the empty target so that we don't miss these breakpoints if > this is still an issue. Then the when we receive the exec-file packet, we > set the file on the target > > > Breakpoints set before any target is created are set on the dummy target. > Breakpoints on the dummy target are copied into any new targets. So this > should not be necessary. If that wasn't working we should figure that out, > but it's not the responsibility of the MI to get this right. > > > We are trying not to use the command line and the command line is what > uses the dummy target automatically. When using the SB API you use a > lldb::SBTarget to set the breakpoint on so you need a target. What do you > suggest we use for the target? I would rather the lldb-mi code not rely on > the currently selected target or the dummy target. > > > - remove all uses of HandleCommand and use SB APIs where possible > - Add any SB API that might be missing and require us to use HandleCommand > > > The rest of these seem good guidelines. > > Jim > > > Good luck and let us know if you have any questions, > > Greg Clayton > > > On Apr 23, 2018, at 3:19 PM, Adrian Prantl via lldb-dev < > lldb-dev@lists.llvm.org> wrote: > > Please join me in welcoming Alexander Polyakov, who will be working on > cleaning up and completing LLDB's lldb-mi fronted as part of his Google > Summer Of Code project: > > Reimplement lldb-mi on top of the LLDB public SB API > https://summerofcode.withgoogle.com/projects/#5427847301169152 > > -- adrian > _______________________________________________ > lldb-dev mailing list > lldb-dev@lists.llvm.org > http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-dev > > > _______________________________________________ > lldb-dev mailing list > lldb-dev@lists.llvm.org > http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-dev > > >
_______________________________________________ lldb-dev mailing list lldb-dev@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-dev