Matt, I really appreciate these suggestions. I'd love to get your participation in the project to make these changes, but understand if you are unable to actively participate. Can you add these to the feature requests so we can track them. I don't need anything fancy, just a paste of an e-mail into the feature request would be great.
Paul -----Original Message----- From: [EMAIL PROTECTED] [mailto:[EMAIL PROTECTED] On Behalf Of Xiaoyong Su Sent: Friday, December 07, 2007 1:24 PM To: LLRP Toolkit Development List Subject: Re: [ltk-d] [LTKNET] Load a message or parameter from XML No problem to make them as abstract class. Regarding the second issue, the original point is to use the LTK .Net library in the fashion of binary->object->xml text (vice versa or any two which are close) without intention of providing XML operation in the library. Of cause we can add functionality based on practice. Both LoadXmlNode and ToXmlNode are valuable. Xiaoyong -----Original Message----- From: [EMAIL PROTECTED] [mailto:[EMAIL PROTECTED] On Behalf Of Matt Moeller Sent: Friday, December 07, 2007 12:59 PM To: 'LLRP Toolkit Development List' Subject: [ltk-d] [LTKNET] Load a message or parameter from XML I would like to suggest some changes to the Parameter and Message base classes in LLRPDataType.cs Firstly I would like to propose that they both be made abstract classes as it doesn't make sense to be able to instantiate either. This would also allow us to define method signature that inheriting classes would have to implement (similar to how interfaces work). Secondly I would like to propose adding a new method that utilizes the abstractness of the class: public abstract void LoadXmlNode(XmlNode node); This would guarantee every inheriting class has a method to load data into itself from an XmlNode. I have found this to be extremely useful in my testing so if you have any questions or doubts please let me know. If it appears there is a positive consensus on this I can go ahead and submit a patch to make these changes. -Matt ------------------------------------------------------------------------ - SF.Net email is sponsored by: Check out the new SourceForge.net Marketplace. It's the best place to buy or sell services for just about anything Open Source. http://sourceforge.net/services/buy/index.php _______________________________________________ llrp-toolkit-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/llrp-toolkit-devel ------------------------------------------------------------------------ - SF.Net email is sponsored by: Check out the new SourceForge.net Marketplace. It's the best place to buy or sell services for just about anything Open Source. http://sourceforge.net/services/buy/index.php _______________________________________________ llrp-toolkit-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/llrp-toolkit-devel ------------------------------------------------------------------------- SF.Net email is sponsored by: Check out the new SourceForge.net Marketplace. It's the best place to buy or sell services for just about anything Open Source. http://sourceforge.net/services/buy/index.php _______________________________________________ llrp-toolkit-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/llrp-toolkit-devel
