> -----Original Message----- > From: Tom Stellard [mailto:[email protected]] > Sent: 01 December 2014 16:19 > To: Daniel Sanders > Cc: [email protected] > Subject: Re: llvm-branch-commits Digest, Vol 69, Issue 3 > > ----------------------------------------------------------------- > > > > Message: 1 > > Date: Mon, 01 Dec 2014 11:22:34 -0000 > > From: Daniel Sanders <[email protected]> > > To: [email protected] > > Subject: [llvm-branch-commits] [llvm-branch] r223007 - Merged from > > r214493: > > Message-ID: <[email protected]> > > Content-Type: text/plain; charset="utf-8" > > > > Author: dsanders > > Date: Mon Dec 1 05:22:34 2014 > > New Revision: 223007 > > > > URL: http://llvm.org/viewvc/llvm-project?rev=223007&view=rev > > Log: > > Merged from r214493: > > > > [mips][PR19612] Fix va_arg for big-endian mode. > > > > Summary: > > Big-endian mode was not correctly adjusting the offset for types smaller > > than an ABI slot. > > > > Fixes PR19612 > > > > Reviewers: dsanders > > > > Reviewed By: dsanders > > > > Subscribers: sstankovic, llvm-commits > > > > Differential Revision: http://reviews.llvm.org/D4556 > > > > > > Added: > > llvm/branches/release_35/test/CodeGen/Mips/cconv/arguments- > varargs.ll > > Modified: > > llvm/branches/release_35/lib/Target/Mips/MipsISelLowering.cpp > > llvm/branches/release_35/lib/Target/Mips/MipsISelLowering.h > > llvm/branches/release_35/test/CodeGen/Mips/cconv/arguments-hard- > float-varargs.ll > > > > Modified: > llvm/branches/release_35/lib/Target/Mips/MipsISelLowering.cpp > > URL: http://llvm.org/viewvc/llvm- > project/llvm/branches/release_35/lib/Target/Mips/MipsISelLowering.cpp?r > ev=223007&r1=223006&r2=223007&view=diff > > > > <snip> > > --- llvm/branches/release_35/lib/Target/Mips/MipsISelLowering.h > (original) > > +++ llvm/branches/release_35/lib/Target/Mips/MipsISelLowering.h Mon > Dec 1 05:22:34 2014 > > @@ -482,6 +482,7 @@ namespace llvm { > > SDValue lowerSELECT_CC(SDValue Op, SelectionDAG &DAG) const; > > SDValue lowerSETCC(SDValue Op, SelectionDAG &DAG) const; > > SDValue lowerVASTART(SDValue Op, SelectionDAG &DAG) const; > > + SDValue lowerVAARG(SDValue Op, SelectionDAG &DAG) const; > > Could you make this function private to avoid adding a new symbol to > libLLVM-3.5.so > > -Tom
I just went to add 'private:' and found that lowerVAARG() is already private. The existing lowerVASTART() is also private and has a symbol in libLLVM-3.5.so. At this point, I'm not sure what you are asking me to do. I guessed that you might be asking me to use LLVM_LIBRARY_VISIBILITY but that doesn't delete the symbol. Could you clarify? _______________________________________________ llvm-branch-commits mailing list [email protected] http://lists.cs.uiuc.edu/mailman/listinfo/llvm-branch-commits
