Author: Simon Pilgrim Date: 2021-01-07T14:21:55Z New Revision: 037b058e41979fa5e6ffd209033dfe72abb97b53
URL: https://github.com/llvm/llvm-project/commit/037b058e41979fa5e6ffd209033dfe72abb97b53 DIFF: https://github.com/llvm/llvm-project/commit/037b058e41979fa5e6ffd209033dfe72abb97b53.diff LOG: [AArch64] SVEIntrinsicOpts - use range loop and cast<> instead of dyn_cast<> for dereferenced pointer. NFCI. Don't directly dereference a dyn_cast<> - use cast<> so we assert for the correct type. Also, simplify the for loop to a range loop. Fixes clang static analyzer warning. Added: Modified: llvm/lib/Target/AArch64/SVEIntrinsicOpts.cpp Removed: ################################################################################ diff --git a/llvm/lib/Target/AArch64/SVEIntrinsicOpts.cpp b/llvm/lib/Target/AArch64/SVEIntrinsicOpts.cpp index 67fc4ee0a29d..8e8b12c07bbf 100644 --- a/llvm/lib/Target/AArch64/SVEIntrinsicOpts.cpp +++ b/llvm/lib/Target/AArch64/SVEIntrinsicOpts.cpp @@ -248,10 +248,8 @@ bool SVEIntrinsicOpts::runOnModule(Module &M) { case Intrinsic::aarch64_sve_ptest_any: case Intrinsic::aarch64_sve_ptest_first: case Intrinsic::aarch64_sve_ptest_last: - for (auto I = F.user_begin(), E = F.user_end(); I != E;) { - auto *Inst = dyn_cast<Instruction>(*I++); - Functions.insert(Inst->getFunction()); - } + for (User *U : F.users()) + Functions.insert(cast<Instruction>(U)->getFunction()); break; default: break; _______________________________________________ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits