================
@@ -45,10 +45,11 @@ set(LLVM_ENABLE_OPENCSD "OFF" CACHE STRING "Use OpenCSD if 
available. Can be ON,
 set(LLVM_HAVE_OPENCSD OFF CACHE BOOL "Is OpenCSD available" FORCE)
 
 # Minimum OpenCSD release that exposes every symbol referenced by
-# ETMTraceDecoder.cpp. OCSD_OPFLG_CHK_RANGE_CONTINUE was introduced in
-# OpenCSD 1.5.4; older releases (e.g. the 1.2.0 shipped by Debian/Ubuntu)
+# ETMTraceDecoder.cpp. OCSD_BUILTIN_DCD_ITM was introduced in OpenCSD 1.7.1,
+# and the ITM packet headers (ocsd_itm_cfg) were exposed in the installed C API
+# in OpenCSD 1.8.4; older releases (e.g. the 1.2.0 shipped by Debian/Ubuntu)
 # build the OpenCSD library but cannot satisfy our use of the C API.
-set(LLVM_OPENCSD_MIN_VERSION "1.5.4")
+set(LLVM_OPENCSD_MIN_VERSION "1.8.4")
----------------
gulfemsavrun wrote:

Thanks for bringing this up! When we added `LLVM_OPENCSD_MIN_VERSION` in 
[https://github.com/llvm/llvm-project/pull/194730](https://github.com/llvm/llvm-project/pull/194730)
 (see 
[https://github.com/llvm/llvm-project/pull/194643](https://github.com/llvm/llvm-project/pull/194643)
 for more context), we picked `1.5.4` simply because it was the first release 
with `OCSD_OPFLG_CHK_RANGE_CONTINUE` (the newest symbol `ETMTraceDecoder.cpp` 
used at the time). This is all part of the new ETM/ITM support in 
`llvm-profgen` (`LLVM_ENABLE_OPENCSD` defaults to `OFF`), and I'm not aware of 
any current users relying on 1.5.4–1.8.3. I'd love to keep a single minimum 
version (`1.8.4`) so we don't have to maintain `#ifdef` guards in 
`ETMTraceDecoder.cpp` and separate lit features (`opencsd` vs `opencsd-itm`), 
but if you think there are users on those versions, I'm happy to add that!

https://github.com/llvm/llvm-project/pull/230310
_______________________________________________
llvm-branch-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

Reply via email to