https://github.com/s-barannikov commented:

It looks like most of my comments (which I left in the former unsplit PR) have 
been addressed. Added some more.

The changes look good to me overall. My general concern is the scope of changes 
and their testability. I'd prefer this PR to be split further into an NFC 
change (propagating TextEncodingConverter), and then a series of small PRs that 
we could prove have decent test coverage.


https://github.com/llvm/llvm-project/pull/196568
_______________________________________________
llvm-branch-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

Reply via email to