hawkinsw wrote: > > > > If you are okay with the suggestions that I made for some typos in the > > > > documentation, I will preemptively incorporate it into my documentation > > > > PR. > > > > > > > > > Thanks for the suggestions! Please do no incorporate these in your PR. > > > Other reviewers may have other suggestions which you then need to > > > incorporate too. It's a lot easier, for both of us, when you finish the > > > documentation PR and after you merged your branch I move the comments of > > > this patch to the new location. I left this comment for other reviewers > > > so they don't need to comment on it. This is how we typically resolve > > > conflicts between patches. > > > > > > That makes total sense. I had already added the following to my PR (in case > > you are interested in incorporating here): > > but I will gladly revert that if you think it's a good idea. > > Yes otherwise we need to block your patch on this patch. > > > Sorry for the confusion -- just trying to be helpful! > > No problem, I appreciate your help!
FYI: I have reverted the patch! https://github.com/llvm/llvm-project/pull/76246 _______________________________________________ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
