[llvm-branch-commits] [Flang][OpenMP][MLIR] Extend derived (record) type map support in Flang OpenMP by adding some initial support for explicit member mapping (PR #81511)

[Kareem Ergawy via llvm-branch-commits]

https://github.com/ergawy commented:

I reviewed the entire PR and commented on all what I thought worth mentioning. 
But I will leave the approval to people working on this longer than I am. 
Hopefully my review makes other reviewers go over the PR faster.

One comment about the lit tests in the PR in general: I see in quite a few 
places, there are `CHECK` lines that use the SSA names directly (e.g. `%20`). I 
think this is fragile and it would be better to either capture the name of the 
SSA value if we care about it and want to check it later (i.e. using 
`%[[name:.*]]`) or capture and discard the name of the value in a generic way 
(i.e. using `%{{.*}}`).

Thanks Andrew for answering my questions.

https://github.com/llvm/llvm-project/pull/81511
_______________________________________________
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits