clementval wrote: > > Wouldn't it be cleaner to expose the patterns via a > > `populateFirCfgConversionPatterns` function and reuse it in you extra pass > > instead of making two pass from the initial file? > > We did this recently for the FirToLLVM patterns. #83492 > > Thanks for taking a look at this. I have extracted the patterns into an > externally visible function, but I don't understand the benefit of splitting > the two CFG conversion passes out into different files. I think this could be > confusing because it would be unclear which file one should contain the > definition of those conversion patterns. Keeping it in one file makes it > clear that both do exactly the same thing on different target operations.
Wouldn't applying the patterns on the module in a single pass work here as well? https://github.com/llvm/llvm-project/pull/84953 _______________________________________________ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
