kbeyls wrote: > [37c84b9](https://github.com/llvm/llvm-project/pull/94394/commits/37c84b9dce70f40db8a7c27b7de8232c4d10f78f) > shows what I had in mind, let me know what you all think. I added: > > ``` > void getSipHash_2_4_64(ArrayRef<uint8_t> In, const uint8_t (&K)[16], > uint8_t (&Out)[8]); > > void getSipHash_2_4_128(ArrayRef<uint8_t> In, const uint8_t (&K)[16], > uint8_t (&Out)[16]); > ``` > > as the core interfaces, and mimicked the ref. test harness to reuse the same > test vectors. If this seems reasonable to yall I'm happy to extract the > vectors.h file from the ref. implementation into the "Import original > sources" PR – that's why I kept it open ;)
Thanks, that looks good to me. https://github.com/llvm/llvm-project/pull/94394 _______________________________________________ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
