[llvm-branch-commits] [clang] [serialization] No transitive type change (PR #92511)

[Ilya Biryukov via llvm-branch-commits]

================
@@ -7392,27 +7388,28 @@ QualType ASTReader::GetType(TypeID ID) {
   return TypesLoaded[Index].withFastQualifiers(FastQuals);
 }
 
-QualType ASTReader::getLocalType(ModuleFile &F, unsigned LocalID) {
+QualType ASTReader::getLocalType(ModuleFile &F, TypeID LocalID) {
----------------
ilya-biryukov wrote:

Could we clarify what `LocalID` means here in a comment somewhere?
IIUC, the `ModuleFileIndex` there is an index into `F.TransitiveImports` rather 
than into a "global" module manager.

Previously, we had distinction between `unsigned` in parameters to this 
function and `TypeID` as a return type.
Maybe we should keep this here and accept `uint64_t` to avoid confusing the 
common global module file index and a local file index?

https://github.com/llvm/llvm-project/pull/92511
_______________________________________________
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits