================ @@ -1492,7 +1466,7 @@ genParallelOp(lower::AbstractConverter &converter, lower::SymMap &symTable, firOpBuilder.createBlock(®ion, /*insertPt=*/{}, allRegionArgTypes, allRegionArgLocs); - llvm::SmallVector<const semantics::Symbol *> allSymbols = reductionSyms; + llvm::SmallVector<const semantics::Symbol *> allSymbols(reductionSyms); ---------------- tblah wrote:
ultra-nit, feel free to ignore Personally I don't like using `()` here because it can parse (to humans and computers) like a function declaration. ```suggestion llvm::SmallVector<const semantics::Symbol *> allSymbols{reductionSyms}; ``` https://github.com/llvm/llvm-project/pull/97566 _______________________________________________ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits