[llvm-branch-commits] [llvm] [DirectX] Error handling improve in root signature metadata Parser (PR #149232)

[Finn Plummer via llvm-branch-commits]

================
@@ -111,14 +110,25 @@ analyzeModule(Module &M) {
       reportError(Ctx, "Root Element is not a metadata node.");
       continue;
     }
-    mcdxbc::RootSignatureDesc RSD;
-    if (std::optional<uint32_t> Version = extractMdIntValue(RSDefNode, 2))
-      RSD.Version = *Version;
+    uint32_t Version = 1;
+    if (std::optional<uint32_t> V = extractMdIntValue(RSDefNode, 2))
+      Version = *V;
     else {
       reportError(Ctx, "Invalid RSDefNode value, expected constant int");
       continue;
     }
 
+    llvm::hlsl::rootsig::MetadataParser MDParser(RootElementListNode);
+    llvm::Expected<mcdxbc::RootSignatureDesc> RSDOrErr =
+        MDParser.ParseRootSignature(Version);
----------------
inbelic wrote:

```suggestion
        MDParser.ParseRootSignature(Version.value());
```

https://github.com/llvm/llvm-project/pull/149232
_______________________________________________
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits