================
@@ -67,6 +67,11 @@ static cl::opt<std::string> DebugBinPath(
              "from it instead of the executable binary."),
     cl::cat(ProfGenCategory));
 
+static cl::opt<std::string> DataAccessProfileFilename(
+    "data-access-profile", cl::value_desc("data-access-profile"),
+    cl::desc("Path to the data access profile to be generated."),
+    cl::cat(ProfGenCategory));
+
----------------
wlei-llvm wrote:

if I understand correctly, this is the input perf trace not the generated 
output, then how about renaming it to something like `data-access-perftrace` or 
`data-access-perfscript`? In llvm-profgen, the "profile" is usually referred to 
the output of this tool. This also aligns with the parsing 
function("parseDataAccessPerfTraces").

Also, the comment "Path to the data access profile to be generated." made me 
think this refers to the output file, which could be confusing.

https://github.com/llvm/llvm-project/pull/148013
_______________________________________________
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

Reply via email to