llvmbot wrote:
<!--LLVM PR SUMMARY COMMENT--> @llvm/pr-subscribers-llvm-analysis Author: Ryotaro Kasuga (kasuga-fj) <details> <summary>Changes</summary> As some code was removed in #<!-- -->169927, `ExtraGCD` in `gcdMIVtest` is no longer necessary. This patch removes it and also adjust the comments. --- Full diff: https://github.com/llvm/llvm-project/pull/172004.diff 1 Files Affected: - (modified) llvm/lib/Analysis/DependenceAnalysis.cpp (+1-7) ``````````diff diff --git a/llvm/lib/Analysis/DependenceAnalysis.cpp b/llvm/lib/Analysis/DependenceAnalysis.cpp index b5d1a325d6ffe..211dd9967c05e 100644 --- a/llvm/lib/Analysis/DependenceAnalysis.cpp +++ b/llvm/lib/Analysis/DependenceAnalysis.cpp @@ -2606,7 +2606,6 @@ bool DependenceInfo::gcdMIVtest(const SCEV *Src, const SCEV *Dst, } const SCEV *DstConst = Coefficients; - APInt ExtraGCD = APInt::getZero(BitWidth); const SCEV *Delta = minusSCEVNoSignedOverflow(DstConst, SrcConst, *SE); if (!Delta) return false; @@ -2633,11 +2632,6 @@ bool DependenceInfo::gcdMIVtest(const SCEV *Src, const SCEV *Dst, // which is infeasible, so we can disallow the = direction for the i level. // Setting j = j' doesn't help matters, so we end up with a direction vector // of [<>, *] - // - // Given A[5*i + 10*j*M + 9*M*N] and A[15*i + 20*j*M - 21*N*M + 5], - // we need to remember that the constant part is 5 and the RunningGCD should - // be initialized to ExtraGCD = 30. - LLVM_DEBUG(dbgs() << " ExtraGCD = " << ExtraGCD << '\n'); bool Improved = false; Coefficients = Src; @@ -2645,7 +2639,7 @@ bool DependenceInfo::gcdMIVtest(const SCEV *Src, const SCEV *Dst, dyn_cast<SCEVAddRecExpr>(Coefficients)) { Coefficients = AddRec->getStart(); const Loop *CurLoop = AddRec->getLoop(); - RunningGCD = ExtraGCD; + RunningGCD = 0; const SCEV *SrcCoeff = AddRec->getStepRecurrence(*SE); const SCEV *DstCoeff = SE->getMinusSCEV(SrcCoeff, SrcCoeff); `````````` </details> https://github.com/llvm/llvm-project/pull/172004 _______________________________________________ llvm-branch-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
