fabianmcg wrote: > The bug that this is fixing, when was the bug introduced? Since this is the > very last release from the 21.x branch, we generally only want to accept > fixes for regressions or small fixes that have a wide impact. As a > consequence of this being the last release from the 21.x branch, if there are > any issues that may arise from this change, we would not be able to fix it > until the LLVM 22 release. > > Given that, @fabianmcg, do you feel this change is very low risk and a fix > for a recent regression that would merit including in 21.x instead of just > waiting for LLVM 22?
Apologies, I missed the ping The bug has been there since July 2024. The reason that it has gone unnoticed is that properties still have no wide adoption, and the bug triggers in very specific circumstances. In the circumstances that it does trigger, it makes the IR non-roundtripable through bytecode (this is a basic feature, and one that it's usually tested in a lit suite), and it produces no error message making it hard to debug. In terms of impact, without the fix, people might not be able to use OptionalProp. However, given that MLIR still doesn't recommend the usage of releases for dev (ie. we still recommend people to use main), that there are many unsolved issues around properties, and that a downstream can solve the issue without this fix. I would likely not included. Nonetheless, @yu810226 is there a reason you needed to backport this patch? https://github.com/llvm/llvm-project/pull/165768 _______________________________________________ llvm-branch-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
