================
@@ -975,7 +811,27 @@ void RemoveDeadValues::runOnOperation() {
}
});
- cleanUpDeadVals(finalCleanupList);
+ MLIRContext *context = module->getContext();
+ cleanUpDeadVals(context, finalCleanupList);
----------------
rengolin wrote:
IIUC, in case all deletable values are already poison (fixed point above), this
will not be skipped (need to check if the values are actually poison).
The multiple checks in `cleanUpDeadVals` also do not seem to short-cut for the
values that are already poison, and you'll always call `processRegionBranchOp`.
Perhaps just not adding them to the list if they're already poison will make
the list `null` and return early, then the canonicalization below can just do
its job?
https://github.com/llvm/llvm-project/pull/173505
_______________________________________________
llvm-branch-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
