https://github.com/Xazax-hun commented:
Thanks a lot! I did not do a full review yet because before we spend too much time iterating on this, could you do some benchmarks to see if this have any performance costs? Also it would be nice to know how big these trees can grow. I am slo a bit surprised by the size of this PR, I expected it to be a bit larger. Are there cases where we compare the depth of two trees? Should we do full shape comparison in those cases? https://github.com/llvm/llvm-project/pull/195603 _______________________________________________ llvm-branch-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
