github-actions[bot] wrote:
<!--LLVM CODE FORMAT COMMENT: {clang-format}-->
:warning: C/C++ code formatter, clang-format found issues in your code.
:warning:
<details>
<summary>
You can test this locally with the following command:
</summary>
``````````bash
git-clang-format --diff origin/main HEAD --extensions h,cpp --
clang/test/OpenMP/taskgraph_task_clone_codegen.cpp
openmp/runtime/test/taskgraph/taskgraph_firstprivate_saved_nontrivial.cpp
openmp/runtime/test/taskgraph/taskgraph_firstprivate_saved_nontrivial_selfref.cpp
openmp/runtime/test/taskgraph/taskgraph_firstprivate_saved_static.cpp
clang/lib/CodeGen/CGOpenMPRuntime.cpp clang/lib/CodeGen/CGOpenMPRuntime.h
clang/test/OpenMP/taskgraph_firstprivate_saved_ast_print.cpp
openmp/runtime/src/kmp.h openmp/runtime/src/kmp_tasking.cpp
openmp/runtime/test/taskgraph/taskgraph_replayable_saved_stack_depth.cpp
openmp/runtime/test/taskgraph/taskgraph_shared_stack_depth.cpp
--diff_from_common_commit
``````````
:warning:
The reproduction instructions above might return results for more than one PR
in a stack if you are using a stacked PR workflow. You can limit the results by
changing `origin/main` to the base branch/commit you want to compare against.
:warning:
</details>
<details>
<summary>
View the diff from clang-format here.
</summary>
``````````diff
diff --git a/clang/lib/CodeGen/CGOpenMPRuntime.cpp
b/clang/lib/CodeGen/CGOpenMPRuntime.cpp
index a48a6e979..c2fd7dbab 100644
--- a/clang/lib/CodeGen/CGOpenMPRuntime.cpp
+++ b/clang/lib/CodeGen/CGOpenMPRuntime.cpp
@@ -3934,14 +3934,12 @@ emitTaskDupFunction(CodeGenModule &CGM, SourceLocation
Loc,
/// same calling convention as the existing taskloop \c task_dup callback
/// (\c p_task_dup_t in the runtime), letting the runtime invoke either via
/// a single function-pointer type.
-static llvm::Value *
-emitTaskCloneFunction(CodeGenModule &CGM, SourceLocation Loc,
- const OMPExecutableDirective &D,
- QualType KmpTaskTWithPrivatesPtrQTy,
- const RecordDecl *KmpTaskTWithPrivatesQTyRD,
- QualType SharedsTy, QualType SharedsPtrTy,
- const OMPTaskDataTy &Data,
- ArrayRef<PrivateDataTy> Privates) {
+static llvm::Value *emitTaskCloneFunction(
+ CodeGenModule &CGM, SourceLocation Loc, const OMPExecutableDirective &D,
+ QualType KmpTaskTWithPrivatesPtrQTy,
+ const RecordDecl *KmpTaskTWithPrivatesQTyRD, QualType SharedsTy,
+ QualType SharedsPtrTy, const OMPTaskDataTy &Data,
+ ArrayRef<PrivateDataTy> Privates) {
ASTContext &C = CGM.getContext();
auto *DstArg = ImplicitParamDecl::Create(
C, /*DC=*/nullptr, Loc, /*Id=*/nullptr, KmpTaskTWithPrivatesPtrQTy,
diff --git a/openmp/runtime/src/kmp.h b/openmp/runtime/src/kmp.h
index 56e99ef30..826e0009b 100644
--- a/openmp/runtime/src/kmp.h
+++ b/openmp/runtime/src/kmp.h
@@ -4510,9 +4510,8 @@ KMP_EXPORT void __kmpc_taskgraph(ident_t *loc_ref,
kmp_int32 gtid,
void *args);
KMP_EXPORT kmp_uint32 __kmpc_taskgraph_task(
ident_t *loc_ref, kmp_int32 gtid, kmp_task_t *new_task, kmp_int32 flags,
- size_t sizeof_kmp_task_t, size_t sizeof_shareds,
- kmp_int32 ndeps, kmp_depend_info_t *dep_list, kmp_task_relocate_t reloc,
- void *task_clone);
+ size_t sizeof_kmp_task_t, size_t sizeof_shareds, kmp_int32 ndeps,
+ kmp_depend_info_t *dep_list, kmp_task_relocate_t reloc, void *task_clone);
KMP_EXPORT kmp_uint32 __kmpc_taskgraph_taskloop(
ident_t *loc_ref, kmp_int32 gtid, kmp_task_t *new_task, kmp_int32 flags,
kmp_int32 if_val, kmp_uint64 *lb, kmp_uint64 *ub, kmp_int64 st,
diff --git
a/openmp/runtime/test/taskgraph/taskgraph_firstprivate_saved_nontrivial.cpp
b/openmp/runtime/test/taskgraph/taskgraph_firstprivate_saved_nontrivial.cpp
index 180a1df1d..a10f306d8 100644
--- a/openmp/runtime/test/taskgraph/taskgraph_firstprivate_saved_nontrivial.cpp
+++ b/openmp/runtime/test/taskgraph/taskgraph_firstprivate_saved_nontrivial.cpp
@@ -55,7 +55,7 @@ __attribute__((noinline)) static void
run_taskgraph_nontrivial(int seed) {
#pragma omp taskgraph graph_id(927)
{
-#pragma omp task firstprivate(saved: Local) shared(observed)
+#pragma omp task firstprivate(saved : Local) shared(observed)
{
// Each replay must observe the value captured at recording time
// (which was 11). If the per-replay destructor deferral were
diff --git
a/openmp/runtime/test/taskgraph/taskgraph_firstprivate_saved_nontrivial_selfref.cpp
b/openmp/runtime/test/taskgraph/taskgraph_firstprivate_saved_nontrivial_selfref.cpp
index 32fa0c7b3..dfad59bb4 100644
---
a/openmp/runtime/test/taskgraph/taskgraph_firstprivate_saved_nontrivial_selfref.cpp
+++
b/openmp/runtime/test/taskgraph/taskgraph_firstprivate_saved_nontrivial_selfref.cpp
@@ -44,7 +44,7 @@ __attribute__((noinline)) static void
run_taskgraph_selfref(int seed) {
#pragma omp taskgraph graph_id(3142)
{
-#pragma omp task firstprivate(saved: Local) \
+#pragma omp task firstprivate(saved : Local)
\
shared(observed_via_self, observed_value)
{
// Read through the self pointer. This is exactly the operation that
diff --git
a/openmp/runtime/test/taskgraph/taskgraph_firstprivate_saved_static.cpp
b/openmp/runtime/test/taskgraph/taskgraph_firstprivate_saved_static.cpp
index 9f8f65523..ae613e2be 100644
--- a/openmp/runtime/test/taskgraph/taskgraph_firstprivate_saved_static.cpp
+++ b/openmp/runtime/test/taskgraph/taskgraph_firstprivate_saved_static.cpp
@@ -36,12 +36,11 @@ run_taskgraph_saved_static(int *out_fs, int *out_fsc, int
*out_local,
#pragma omp taskgraph graph_id(811)
{
-#pragma omp task firstprivate(saved: FileScopeStaticInt,
\
- FileScopeConstStaticInt, LocalStaticInt,
\
- WithStaticMember::StaticMember,
\
- WithStaticMember::StaticConstMember)
\
- shared(out_fs, out_fsc, out_local, out_member,
\
- out_member_const)
+#pragma omp task firstprivate(saved : FileScopeStaticInt,
\
+ FileScopeConstStaticInt, LocalStaticInt,
\
+ WithStaticMember::StaticMember,
\
+ WithStaticMember::StaticConstMember)
\
+ shared(out_fs, out_fsc, out_local, out_member, out_member_const)
{
*out_fs = FileScopeStaticInt;
*out_fsc = FileScopeConstStaticInt;
@@ -93,7 +92,8 @@ int main() {
if (failed)
return 1;
- std::fprintf(stderr, "PASS firstprivate(saved) statics persist across
replays\n");
+ std::fprintf(stderr,
+ "PASS firstprivate(saved) statics persist across replays\n");
return 0;
}
``````````
</details>
https://github.com/llvm/llvm-project/pull/200408
_______________________________________________
llvm-branch-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
