smithp35 wrote: Are there any links to ABI or other documentation that covers the format and ideally design of AMD specific things like `.amdgpu.info`, `SHN_AMDGPU_LDS` and `named-barrier` symbols? Would be good to post links to these in the PR description.
I have similar concerns to MaskRay about maintainability. If someone complained that there was a bug, or some refactoring was needed would anyone outside of AMD have a chance of resolving it? I think it would be useful to describe how this code interacts with the general parts of LLD in terms of inputs and outputs, and what invariants need to be followed. The large pass could then be treated by LLD developers as a kind of black box. Would likely need an owner from AMD to look after it. https://github.com/llvm/llvm-project/pull/206787 _______________________________________________ llvm-branch-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
