llvmorg-github-actions[bot] wrote:
<!--LLVM PR SUMMARY COMMENT--> @llvm/pr-subscribers-lldb Author: Aiden Grossman (boomanaiden154) <details> <summary>Changes</summary> The lit external shell is going to be removed soon, so drop support for using it to run the LLDB tests. --- Full diff: https://github.com/llvm/llvm-project/pull/209627.diff 2 Files Affected: - (modified) lldb/test/Shell/helper/toolchain.py (+4-4) - (modified) lldb/test/Shell/lit.cfg.py (+1-10) ``````````diff diff --git a/lldb/test/Shell/helper/toolchain.py b/lldb/test/Shell/helper/toolchain.py index c00985a8ef615..8396fabd6e9fd 100644 --- a/lldb/test/Shell/helper/toolchain.py +++ b/lldb/test/Shell/helper/toolchain.py @@ -49,10 +49,10 @@ def get_lldb_args(config, suffix=""): class ShTestLldb(ShTest): - def __init__( - self, execute_external=False, extra_substitutions=[], preamble_commands=[] - ): - super().__init__(execute_external, extra_substitutions, preamble_commands) + def __init__(self, extra_substitutions=[], preamble_commands=[]): + super().__init__( + extra_substitutions=extra_substitutions, preamble_commands=preamble_commands + ) def execute(self, test, litConfig): exec_path = test.getExecPath() diff --git a/lldb/test/Shell/lit.cfg.py b/lldb/test/Shell/lit.cfg.py index 238f57b69ff7c..134dba7f1c494 100644 --- a/lldb/test/Shell/lit.cfg.py +++ b/lldb/test/Shell/lit.cfg.py @@ -20,16 +20,7 @@ # name: The name of this test suite. config.name = "lldb-shell" -# testFormat: The test format to use to interpret tests. -# We prefer the lit internal shell which provides a better user experience on -# failures and is faster unless the user explicitly disables it with -# LIT_USE_INTERNAL_SHELL=0 env var. -use_lit_shell = True -lit_shell_env = os.environ.get("LIT_USE_INTERNAL_SHELL") -if lit_shell_env: - use_lit_shell = lit.util.pythonize_bool(lit_shell_env) - -config.test_format = toolchain.ShTestLldb(not use_lit_shell) +config.test_format = toolchain.ShTestLldb() # suffixes: A list of file extensions to treat as test files. This is overriden # by individual lit.local.cfg files in the test subdirectories. `````````` </details> https://github.com/llvm/llvm-project/pull/209627 _______________________________________________ llvm-branch-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
