================ @@ -355,7 +355,8 @@ exit: ret i32 %x } -; TODO: We can PRE via splitting of the critical edge in the cold path. +; TODO: not PRE'd because the pointer may be freed, so reloading is unsafe. +; The cold-path critical edge is split once the pointer is known non-freeable. ---------------- antoniofrighetto wrote:
I'm not really sure why a TODO was originally left here. Let's either mark the function as nofree, or drop the TODO: ```suggestion ; Not PRE'd because the pointer may be freed, so reloading would be unsafe. ``` (Same below.) https://github.com/llvm/llvm-project/pull/206694 _______________________________________________ llvm-branch-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
