https://github.com/Sukumarsawant updated https://github.com/llvm/llvm-project/pull/217409
>From 08716de515249b3a849517a556dac4b32f0c619d Mon Sep 17 00:00:00 2001 From: Sukumarsawant <[email protected]> Date: Wed, 19 Aug 2026 23:12:43 +0530 Subject: [PATCH 1/2] fmaximum_numf128 --- libc/config/baremetal/aarch64/entrypoints.txt | 2 +- libc/config/baremetal/arm/entrypoints.txt | 2 +- libc/config/baremetal/riscv/entrypoints.txt | 2 +- libc/config/darwin/aarch64/entrypoints.txt | 2 +- libc/config/darwin/x86_64/entrypoints.txt | 1 + libc/config/freebsd/x86_64/entrypoints.txt | 2 +- libc/config/gpu/amdgpu/entrypoints.txt | 1 + libc/config/gpu/nvptx/entrypoints.txt | 1 + libc/config/linux/aarch64/entrypoints.txt | 2 +- libc/config/linux/arm/entrypoints.txt | 1 + libc/config/linux/riscv/entrypoints.txt | 2 +- libc/config/linux/x86_64/entrypoints.txt | 2 +- libc/config/windows/entrypoints.txt | 1 + libc/shared/math/fmaximum_numf128.h | 6 ------ libc/src/__support/math/CMakeLists.txt | 2 +- libc/src/__support/math/fmaximum_numf128.h | 11 ++++------- libc/src/math/fmaximum_numf128.h | 5 +++++ libc/src/math/generic/CMakeLists.txt | 1 + libc/src/math/generic/fmaximum_numf128.cpp | 6 +++++- libc/test/shared/shared_math_constexpr_test.cpp | 6 +++--- libc/test/shared/shared_math_test.cpp | 4 ++-- libc/test/src/math/smoke/CMakeLists.txt | 1 + libc/test/src/math/smoke/FMaximumNumTest.h | 2 +- libc/test/src/math/smoke/fmaximum_numf128_test.cpp | 5 +++++ utils/bazel/llvm-project-overlay/libc/BUILD.bazel | 4 +++- .../libc/test/src/math/smoke/BUILD.bazel | 3 +++ 26 files changed, 47 insertions(+), 30 deletions(-) diff --git a/libc/config/baremetal/aarch64/entrypoints.txt b/libc/config/baremetal/aarch64/entrypoints.txt index aff61e99ac684..8d504e5cabc7e 100644 --- a/libc/config/baremetal/aarch64/entrypoints.txt +++ b/libc/config/baremetal/aarch64/entrypoints.txt @@ -432,6 +432,7 @@ set(TARGET_LIBM_ENTRYPOINTS libc.src.math.fmaximum_magl libc.src.math.fmaximum_num libc.src.math.fmaximum_numf + libc.src.math.fmaximum_numf128 libc.src.math.fmaximum_numl libc.src.math.fmaximumf libc.src.math.fmaximumf128 @@ -762,7 +763,6 @@ if(LIBC_TYPES_HAS_NATIVE_FLOAT128) libc.src.math.ffmaf128 libc.src.math.fmaximum_mag_numf128 libc.src.math.fmaximum_magf128 - libc.src.math.fmaximum_numf128 libc.src.math.fminimum_mag_numf128 libc.src.math.fminimum_magf128 libc.src.math.fminimum_numf128 diff --git a/libc/config/baremetal/arm/entrypoints.txt b/libc/config/baremetal/arm/entrypoints.txt index cacedc40866e4..406f63f1df369 100644 --- a/libc/config/baremetal/arm/entrypoints.txt +++ b/libc/config/baremetal/arm/entrypoints.txt @@ -444,6 +444,7 @@ set(TARGET_LIBM_ENTRYPOINTS libc.src.math.fmaximum_magl libc.src.math.fmaximum_num libc.src.math.fmaximum_numf + libc.src.math.fmaximum_numf128 libc.src.math.fmaximum_numl libc.src.math.fmaximumf libc.src.math.fmaximumf128 @@ -773,7 +774,6 @@ if(LIBC_TYPES_HAS_NATIVE_FLOAT128) libc.src.math.ffmaf128 libc.src.math.fmaximum_mag_numf128 libc.src.math.fmaximum_magf128 - libc.src.math.fmaximum_numf128 libc.src.math.fminimum_mag_numf128 libc.src.math.fminimum_magf128 libc.src.math.fminimum_numf128 diff --git a/libc/config/baremetal/riscv/entrypoints.txt b/libc/config/baremetal/riscv/entrypoints.txt index 8a7b5a329e4e1..04918d70b69be 100644 --- a/libc/config/baremetal/riscv/entrypoints.txt +++ b/libc/config/baremetal/riscv/entrypoints.txt @@ -440,6 +440,7 @@ set(TARGET_LIBM_ENTRYPOINTS libc.src.math.fmaximum_magl libc.src.math.fmaximum_num libc.src.math.fmaximum_numf + libc.src.math.fmaximum_numf128 libc.src.math.fmaximum_numl libc.src.math.fmaximumf libc.src.math.fmaximumf128 @@ -770,7 +771,6 @@ if(LIBC_TYPES_HAS_NATIVE_FLOAT128) libc.src.math.ffmaf128 libc.src.math.fmaximum_mag_numf128 libc.src.math.fmaximum_magf128 - libc.src.math.fmaximum_numf128 libc.src.math.fminimum_mag_numf128 libc.src.math.fminimum_magf128 libc.src.math.fminimum_numf128 diff --git a/libc/config/darwin/aarch64/entrypoints.txt b/libc/config/darwin/aarch64/entrypoints.txt index 96f310e4fc05d..bad582299d3ad 100644 --- a/libc/config/darwin/aarch64/entrypoints.txt +++ b/libc/config/darwin/aarch64/entrypoints.txt @@ -251,6 +251,7 @@ set(TARGET_LIBM_ENTRYPOINTS libc.src.math.fmaximum_magl libc.src.math.fmaximum_num libc.src.math.fmaximum_numf + libc.src.math.fmaximum_numf128 libc.src.math.fmaximum_numl libc.src.math.fmaximumf libc.src.math.fmaximumf128 @@ -582,7 +583,6 @@ if(LIBC_TYPES_HAS_NATIVE_FLOAT128) libc.src.math.ffmaf128 libc.src.math.fmaximum_mag_numf128 libc.src.math.fmaximum_magf128 - libc.src.math.fmaximum_numf128 libc.src.math.fminimum_mag_numf128 libc.src.math.fminimum_magf128 libc.src.math.fminimum_numf128 diff --git a/libc/config/darwin/x86_64/entrypoints.txt b/libc/config/darwin/x86_64/entrypoints.txt index a7760b2b6ef40..b22723eee2930 100644 --- a/libc/config/darwin/x86_64/entrypoints.txt +++ b/libc/config/darwin/x86_64/entrypoints.txt @@ -158,6 +158,7 @@ set(TARGET_LIBM_ENTRYPOINTS #libc.src.math.fmax #libc.src.math.fmaxf #libc.src.math.fmaxf128 + #libc.src.math.fmaximum_numf128 #libc.src.math.fmaximumf128 #libc.src.math.fmaxl #libc.src.math.fmin diff --git a/libc/config/freebsd/x86_64/entrypoints.txt b/libc/config/freebsd/x86_64/entrypoints.txt index 165d4ca33b5d2..4a1e25b34ee81 100644 --- a/libc/config/freebsd/x86_64/entrypoints.txt +++ b/libc/config/freebsd/x86_64/entrypoints.txt @@ -187,6 +187,7 @@ set(TARGET_LIBM_ENTRYPOINTS libc.src.math.fmaximuml libc.src.math.fmaximum_num libc.src.math.fmaximum_numf + libc.src.math.fmaximum_numf128 libc.src.math.fmaximum_numl libc.src.math.fmaximum_mag libc.src.math.fmaximum_magf @@ -521,7 +522,6 @@ if(LIBC_TYPES_HAS_NATIVE_FLOAT128) libc.src.math.ffmaf128 libc.src.math.fmaximum_mag_numf128 libc.src.math.fmaximum_magf128 - libc.src.math.fmaximum_numf128 libc.src.math.fminimum_mag_numf128 libc.src.math.fminimum_magf128 libc.src.math.fminimum_numf128 diff --git a/libc/config/gpu/amdgpu/entrypoints.txt b/libc/config/gpu/amdgpu/entrypoints.txt index 3ce678b24996a..65cfea121d886 100644 --- a/libc/config/gpu/amdgpu/entrypoints.txt +++ b/libc/config/gpu/amdgpu/entrypoints.txt @@ -382,6 +382,7 @@ set(TARGET_LIBM_ENTRYPOINTS libc.src.math.fmaximum_mag_numl libc.src.math.fmaximum_num libc.src.math.fmaximum_numf + libc.src.math.fmaximum_numf128 libc.src.math.fmaximum_numl libc.src.math.fmaxl libc.src.math.fmin diff --git a/libc/config/gpu/nvptx/entrypoints.txt b/libc/config/gpu/nvptx/entrypoints.txt index 9a4dd8560c9f3..d4d6120c98edd 100644 --- a/libc/config/gpu/nvptx/entrypoints.txt +++ b/libc/config/gpu/nvptx/entrypoints.txt @@ -378,6 +378,7 @@ set(TARGET_LIBM_ENTRYPOINTS libc.src.math.fmaximum_mag_numl libc.src.math.fmaximum_num libc.src.math.fmaximum_numf + libc.src.math.fmaximum_numf128 libc.src.math.fmaximum_numl libc.src.math.fmaxl libc.src.math.fmin diff --git a/libc/config/linux/aarch64/entrypoints.txt b/libc/config/linux/aarch64/entrypoints.txt index 461ce848af8ae..b885e26772d12 100644 --- a/libc/config/linux/aarch64/entrypoints.txt +++ b/libc/config/linux/aarch64/entrypoints.txt @@ -592,6 +592,7 @@ set(TARGET_LIBM_ENTRYPOINTS libc.src.math.fmaximum_magl libc.src.math.fmaximum_num libc.src.math.fmaximum_numf + libc.src.math.fmaximum_numf128 libc.src.math.fmaximum_numl libc.src.math.fmaximumf libc.src.math.fmaximumf128 @@ -916,7 +917,6 @@ if(LIBC_TYPES_HAS_NATIVE_FLOAT128) libc.src.math.ffmaf128 libc.src.math.fmaximum_mag_numf128 libc.src.math.fmaximum_magf128 - libc.src.math.fmaximum_numf128 libc.src.math.fminimum_mag_numf128 libc.src.math.fminimum_magf128 libc.src.math.fminimum_numf128 diff --git a/libc/config/linux/arm/entrypoints.txt b/libc/config/linux/arm/entrypoints.txt index 7fde0e4a7b1cd..46ed6df69f88a 100644 --- a/libc/config/linux/arm/entrypoints.txt +++ b/libc/config/linux/arm/entrypoints.txt @@ -419,6 +419,7 @@ set(TARGET_LIBM_ENTRYPOINTS libc.src.math.fmaximum_magl libc.src.math.fmaximum_num libc.src.math.fmaximum_numf + libc.src.math.fmaximum_numf128 libc.src.math.fmaximum_numl libc.src.math.fmaximumf libc.src.math.fmaximumf128 diff --git a/libc/config/linux/riscv/entrypoints.txt b/libc/config/linux/riscv/entrypoints.txt index 372a3052bb542..cd4b74f432e8f 100644 --- a/libc/config/linux/riscv/entrypoints.txt +++ b/libc/config/linux/riscv/entrypoints.txt @@ -660,6 +660,7 @@ set(TARGET_LIBM_ENTRYPOINTS libc.src.math.fmaximum_magl libc.src.math.fmaximum_num libc.src.math.fmaximum_numf + libc.src.math.fmaximum_numf128 libc.src.math.fmaximum_numl libc.src.math.fmaximumf libc.src.math.fmaximumf128 @@ -1001,7 +1002,6 @@ if(LIBC_TYPES_HAS_NATIVE_FLOAT128) libc.src.math.ffmaf128 libc.src.math.fmaximum_mag_numf128 libc.src.math.fmaximum_magf128 - libc.src.math.fmaximum_numf128 libc.src.math.fminimum_mag_numf128 libc.src.math.fminimum_magf128 libc.src.math.fminimum_numf128 diff --git a/libc/config/linux/x86_64/entrypoints.txt b/libc/config/linux/x86_64/entrypoints.txt index 1e9cd4cfdac0d..20ee66f70318d 100644 --- a/libc/config/linux/x86_64/entrypoints.txt +++ b/libc/config/linux/x86_64/entrypoints.txt @@ -670,6 +670,7 @@ set(TARGET_LIBM_ENTRYPOINTS libc.src.math.fmaximum_magl libc.src.math.fmaximum_num libc.src.math.fmaximum_numf + libc.src.math.fmaximum_numf128 libc.src.math.fmaximum_numl libc.src.math.fmaximumf libc.src.math.fmaximumf128 @@ -1011,7 +1012,6 @@ if(LIBC_TYPES_HAS_NATIVE_FLOAT128) libc.src.math.ffmaf128 libc.src.math.fmaximum_mag_numf128 libc.src.math.fmaximum_magf128 - libc.src.math.fmaximum_numf128 libc.src.math.fminimum_mag_numf128 libc.src.math.fminimum_magf128 libc.src.math.fminimum_numf128 diff --git a/libc/config/windows/entrypoints.txt b/libc/config/windows/entrypoints.txt index 568bd2d5ccb2b..d4c25d9d5f074 100644 --- a/libc/config/windows/entrypoints.txt +++ b/libc/config/windows/entrypoints.txt @@ -220,6 +220,7 @@ set(TARGET_LIBM_ENTRYPOINTS libc.src.math.fmaximuml libc.src.math.fmaximum_num libc.src.math.fmaximum_numf + libc.src.math.fmaximum_numf128 libc.src.math.fmaximum_numl libc.src.math.fmaximum_mag libc.src.math.fmaximum_magf diff --git a/libc/shared/math/fmaximum_numf128.h b/libc/shared/math/fmaximum_numf128.h index f26724d537a3f..50557e8d25a14 100644 --- a/libc/shared/math/fmaximum_numf128.h +++ b/libc/shared/math/fmaximum_numf128.h @@ -9,10 +9,6 @@ #ifndef LLVM_LIBC_SHARED_MATH_FMAXIMUM_NUMF128_H #define LLVM_LIBC_SHARED_MATH_FMAXIMUM_NUMF128_H -#include "include/llvm-libc-types/float128.h" - -#ifdef LIBC_TYPES_HAS_NATIVE_FLOAT128 - #include "shared/libc_common.h" #include "src/__support/math/fmaximum_numf128.h" @@ -24,6 +20,4 @@ using math::fmaximum_numf128; } // namespace shared } // namespace LIBC_NAMESPACE_DECL -#endif // LIBC_TYPES_HAS_NATIVE_FLOAT128 - #endif // LLVM_LIBC_SHARED_MATH_FMAXIMUM_NUMF128_H diff --git a/libc/src/__support/math/CMakeLists.txt b/libc/src/__support/math/CMakeLists.txt index bee27901ea822..6d8fa6f32a95e 100644 --- a/libc/src/__support/math/CMakeLists.txt +++ b/libc/src/__support/math/CMakeLists.txt @@ -1052,7 +1052,7 @@ add_header_library( HDRS fmaximum_numf128.h DEPENDS - libc.include.llvm-libc-types.float128 + libc.src.__support.FPUtil.float128 libc.src.__support.FPUtil.basic_operations libc.src.__support.macros.config ) diff --git a/libc/src/__support/math/fmaximum_numf128.h b/libc/src/__support/math/fmaximum_numf128.h index ccee570de2c14..f81f851201538 100644 --- a/libc/src/__support/math/fmaximum_numf128.h +++ b/libc/src/__support/math/fmaximum_numf128.h @@ -9,23 +9,20 @@ #ifndef LLVM_LIBC_SRC___SUPPORT_MATH_FMAXIMUM_NUMF128_H #define LLVM_LIBC_SRC___SUPPORT_MATH_FMAXIMUM_NUMF128_H -#include "include/llvm-libc-types/float128.h" - -#ifdef LIBC_TYPES_HAS_NATIVE_FLOAT128 - #include "src/__support/FPUtil/BasicOperations.h" +#include "src/__support/FPUtil/float128.h" #include "src/__support/macros/config.h" namespace LIBC_NAMESPACE_DECL { namespace math { -LIBC_INLINE constexpr float128 fmaximum_numf128(float128 x, float128 y) { +using LIBC_NAMESPACE::fputil::Float128; + +LIBC_INLINE constexpr Float128 fmaximum_numf128(Float128 x, Float128 y) { return fputil::fmaximum_num(x, y); } } // namespace math } // namespace LIBC_NAMESPACE_DECL -#endif // LIBC_TYPES_HAS_NATIVE_FLOAT128 - #endif // LLVM_LIBC_SRC___SUPPORT_MATH_FMAXIMUM_NUMF128_H diff --git a/libc/src/math/fmaximum_numf128.h b/libc/src/math/fmaximum_numf128.h index 1e9bd8dfb81aa..a4afa4f7b2241 100644 --- a/libc/src/math/fmaximum_numf128.h +++ b/libc/src/math/fmaximum_numf128.h @@ -10,11 +10,16 @@ #ifndef LLVM_LIBC_SRC_MATH_FMAXIMUM_NUMF128_H #define LLVM_LIBC_SRC_MATH_FMAXIMUM_NUMF128_H +#include "src/__support/FPUtil/float128.h" #include "src/__support/macros/config.h" #include "src/__support/macros/properties/types.h" namespace LIBC_NAMESPACE_DECL { +#ifndef LIBC_TYPES_HAS_NATIVE_FLOAT128 +using float128 = LIBC_NAMESPACE::fputil::Float128; +#endif // LIBC_TYPES_HAS_NATIVE_FLOAT128 + float128 fmaximum_numf128(float128 x, float128 y); } // namespace LIBC_NAMESPACE_DECL diff --git a/libc/src/math/generic/CMakeLists.txt b/libc/src/math/generic/CMakeLists.txt index c1c70f2aba6c6..fe0fbe51eadac 100644 --- a/libc/src/math/generic/CMakeLists.txt +++ b/libc/src/math/generic/CMakeLists.txt @@ -2232,6 +2232,7 @@ add_entrypoint_object( HDRS ../fmaximum_numf128.h DEPENDS + libc.src.__support.CPP.bit libc.src.__support.math.fmaximum_numf128 ) diff --git a/libc/src/math/generic/fmaximum_numf128.cpp b/libc/src/math/generic/fmaximum_numf128.cpp index e6bae7947371d..fb164d4f98a18 100644 --- a/libc/src/math/generic/fmaximum_numf128.cpp +++ b/libc/src/math/generic/fmaximum_numf128.cpp @@ -7,12 +7,16 @@ //===----------------------------------------------------------------------===// #include "src/math/fmaximum_numf128.h" +#include "src/__support/CPP/bit.h" #include "src/__support/math/fmaximum_numf128.h" namespace LIBC_NAMESPACE_DECL { +using LIBC_NAMESPACE::fputil::Float128; + LLVM_LIBC_FUNCTION(float128, fmaximum_numf128, (float128 x, float128 y)) { - return math::fmaximum_numf128(x, y); + return cpp::bit_cast<float128>(math::fmaximum_numf128( + cpp::bit_cast<Float128>(x), cpp::bit_cast<Float128>(y))); } } // namespace LIBC_NAMESPACE_DECL diff --git a/libc/test/shared/shared_math_constexpr_test.cpp b/libc/test/shared/shared_math_constexpr_test.cpp index 42554fcff1f51..cf0b878cbb3f5 100644 --- a/libc/test/shared/shared_math_constexpr_test.cpp +++ b/libc/test/shared/shared_math_constexpr_test.cpp @@ -398,6 +398,9 @@ static_assert(Float128(0.0) == static_assert(Float128(0.0) == LIBC_NAMESPACE::shared::fminimumf128(Float128(0.0), Float128(0.0))); +static_assert(Float128(0.0) == + LIBC_NAMESPACE::shared::fmaximum_numf128(Float128(0.0), + Float128(0.0))); static_assert(0LL == LIBC_NAMESPACE::shared::llrintf128(Float128(0.0))); static_assert(0LL == LIBC_NAMESPACE::shared::llroundf128(Float128(0.0))); static_assert(0L == LIBC_NAMESPACE::shared::lrintf128(Float128(0.0))); @@ -434,9 +437,6 @@ static_assert(float128(1.0) == static_assert(0.0f == LIBC_NAMESPACE::shared::fdivf128(float128(0.0), float128(1.0))); static_assert(0.0 == LIBC_NAMESPACE::shared::dsqrtf128(float128(0.0))); -static_assert(float128(0.0) == - LIBC_NAMESPACE::shared::fmaximum_numf128(float128(0.0), - float128(0.0))); static_assert(float128(0.0) == LIBC_NAMESPACE::shared::fminimum_numf128(float128(0.0), float128(0.0))); diff --git a/libc/test/shared/shared_math_test.cpp b/libc/test/shared/shared_math_test.cpp index 6ac5d1a8bf2be..8584839093fe2 100644 --- a/libc/test/shared/shared_math_test.cpp +++ b/libc/test/shared/shared_math_test.cpp @@ -596,6 +596,8 @@ TEST(LlvmLibcSharedMathTest, AllEmuFloat128) { Float128(0.0), Float128(0.0))); EXPECT_FP_EQ(Float128(0.0), LIBC_NAMESPACE::shared::fminimumf128( Float128(0.0), Float128(0.0))); + EXPECT_FP_EQ(Float128(0.0), LIBC_NAMESPACE::shared::fmaximum_numf128( + Float128(0.0), Float128(0.0))); EXPECT_EQ(0LL, LIBC_NAMESPACE::shared::llrintf128(Float128(0.0))); EXPECT_EQ(0LL, LIBC_NAMESPACE::shared::llroundf128(Float128(0.0))); EXPECT_EQ(0L, LIBC_NAMESPACE::shared::lrintf128(Float128(0.0))); @@ -703,8 +705,6 @@ TEST(LlvmLibcSharedMathTest, AllFloat128) { 0.0f16, LIBC_NAMESPACE::shared::f16subf128(float128(0.0), float128(0.0))); EXPECT_FP_EQ(0.0f16, LIBC_NAMESPACE::shared::f16sqrtf128(float128(0.0))); #endif // LIBC_TYPES_HAS_FLOAT16 - EXPECT_FP_EQ(float128(0.0), LIBC_NAMESPACE::shared::fmaximum_numf128( - float128(0.0), float128(0.0))); EXPECT_FP_EQ(float128(0.0), LIBC_NAMESPACE::shared::fminimum_numf128( float128(0.0), float128(0.0))); EXPECT_FP_EQ(float128(0.0), diff --git a/libc/test/src/math/smoke/CMakeLists.txt b/libc/test/src/math/smoke/CMakeLists.txt index 7ea511c2b0a7e..00fdc71ca604b 100644 --- a/libc/test/src/math/smoke/CMakeLists.txt +++ b/libc/test/src/math/smoke/CMakeLists.txt @@ -2976,6 +2976,7 @@ add_fp_unittest( HDRS FMaximumNumTest.h DEPENDS + libc.src.__support.FPUtil.float128 libc.src.math.fmaximum_numf128 libc.src.__support.CPP.algorithm libc.src.__support.FPUtil.fp_bits diff --git a/libc/test/src/math/smoke/FMaximumNumTest.h b/libc/test/src/math/smoke/FMaximumNumTest.h index 14b70f029009d..49e74a3d58468 100644 --- a/libc/test/src/math/smoke/FMaximumNumTest.h +++ b/libc/test/src/math/smoke/FMaximumNumTest.h @@ -80,7 +80,7 @@ class FMaximumNumTest : public LIBC_NAMESPACE::testing::FEnvSafeTest { continue; T x = xbits.get_val(); T y = ybits.get_val(); - if ((x == 0) && (y == 0)) + if ((x == T(0)) && (y == T(0))) continue; if (x > y) diff --git a/libc/test/src/math/smoke/fmaximum_numf128_test.cpp b/libc/test/src/math/smoke/fmaximum_numf128_test.cpp index 6855ea3b39a9c..8eb4df09d5e17 100644 --- a/libc/test/src/math/smoke/fmaximum_numf128_test.cpp +++ b/libc/test/src/math/smoke/fmaximum_numf128_test.cpp @@ -7,7 +7,12 @@ //===----------------------------------------------------------------------===// #include "FMaximumNumTest.h" +#include "src/__support/FPUtil/float128.h" #include "src/math/fmaximum_numf128.h" +#ifndef LIBC_TYPES_HAS_NATIVE_FLOAT128 +using float128 = LIBC_NAMESPACE::fputil::Float128; +#endif // LIBC_TYPES_HAS_NATIVE_FLOAT128 + LIST_FMAXIMUM_NUM_TESTS(float128, LIBC_NAMESPACE::fmaximum_numf128) diff --git a/utils/bazel/llvm-project-overlay/libc/BUILD.bazel b/utils/bazel/llvm-project-overlay/libc/BUILD.bazel index 77b5554c3b1cd..2b7cb92d195bd 100644 --- a/utils/bazel/llvm-project-overlay/libc/BUILD.bazel +++ b/utils/bazel/llvm-project-overlay/libc/BUILD.bazel @@ -5596,8 +5596,8 @@ libc_support_library( hdrs = ["src/__support/math/fmaximum_numf128.h"], deps = [ ":__support_fputil_basic_operations", + ":__support_fputil_float128", ":__support_macros_config", - ":llvm_libc_types_float128", ], ) @@ -11944,6 +11944,8 @@ libc_math_function( libc_math_function( name = "fmaximum_numf128", additional_deps = [ + ":__support_cpp_bit", + ":__support_fputil_float128", ":__support_math_fmaximum_numf128", ], ) diff --git a/utils/bazel/llvm-project-overlay/libc/test/src/math/smoke/BUILD.bazel b/utils/bazel/llvm-project-overlay/libc/test/src/math/smoke/BUILD.bazel index 0b6e6fddcd722..4b8657372f094 100644 --- a/utils/bazel/llvm-project-overlay/libc/test/src/math/smoke/BUILD.bazel +++ b/utils/bazel/llvm-project-overlay/libc/test/src/math/smoke/BUILD.bazel @@ -629,6 +629,9 @@ math_test( math_test( name = "fmaximum_numf128", hdrs = ["FMaximumNumTest.h"], + deps = [ + "//libc:__support_fputil_float128", + ], ) math_test( >From 35adc071e81487adf0d521198f0cba986f3d1fda Mon Sep 17 00:00:00 2001 From: Sukumarsawant <[email protected]> Date: Wed, 19 Aug 2026 23:15:50 +0530 Subject: [PATCH 2/2] fminimum_numf128 --- libc/config/baremetal/aarch64/entrypoints.txt | 2 +- libc/config/baremetal/arm/entrypoints.txt | 2 +- libc/config/baremetal/riscv/entrypoints.txt | 2 +- libc/config/darwin/aarch64/entrypoints.txt | 2 +- libc/config/darwin/x86_64/entrypoints.txt | 1 + libc/config/freebsd/x86_64/entrypoints.txt | 2 +- libc/config/gpu/amdgpu/entrypoints.txt | 1 + libc/config/gpu/nvptx/entrypoints.txt | 1 + libc/config/linux/aarch64/entrypoints.txt | 2 +- libc/config/linux/arm/entrypoints.txt | 1 + libc/config/linux/riscv/entrypoints.txt | 2 +- libc/config/linux/x86_64/entrypoints.txt | 2 +- libc/config/windows/entrypoints.txt | 1 + libc/shared/math/fminimum_numf128.h | 6 ------ libc/src/__support/math/CMakeLists.txt | 2 +- libc/src/__support/math/fminimum_numf128.h | 11 ++++------- libc/src/math/fminimum_numf128.h | 5 +++++ libc/src/math/generic/CMakeLists.txt | 1 + libc/src/math/generic/fminimum_numf128.cpp | 6 +++++- libc/test/shared/shared_math_constexpr_test.cpp | 6 +++--- libc/test/shared/shared_math_test.cpp | 4 ++-- libc/test/src/math/smoke/CMakeLists.txt | 1 + libc/test/src/math/smoke/FMinimumNumTest.h | 2 +- libc/test/src/math/smoke/fminimum_numf128_test.cpp | 5 +++++ utils/bazel/llvm-project-overlay/libc/BUILD.bazel | 4 +++- .../libc/test/src/math/smoke/BUILD.bazel | 3 +++ 26 files changed, 47 insertions(+), 30 deletions(-) diff --git a/libc/config/baremetal/aarch64/entrypoints.txt b/libc/config/baremetal/aarch64/entrypoints.txt index 8d504e5cabc7e..753df5ece57dc 100644 --- a/libc/config/baremetal/aarch64/entrypoints.txt +++ b/libc/config/baremetal/aarch64/entrypoints.txt @@ -450,6 +450,7 @@ set(TARGET_LIBM_ENTRYPOINTS libc.src.math.fminimum_magl libc.src.math.fminimum_num libc.src.math.fminimum_numf + libc.src.math.fminimum_numf128 libc.src.math.fminimum_numl libc.src.math.fminimumf libc.src.math.fminimumf128 @@ -765,7 +766,6 @@ if(LIBC_TYPES_HAS_NATIVE_FLOAT128) libc.src.math.fmaximum_magf128 libc.src.math.fminimum_mag_numf128 libc.src.math.fminimum_magf128 - libc.src.math.fminimum_numf128 libc.src.math.fmodf128 libc.src.math.fmulf128 libc.src.math.frexpf128 diff --git a/libc/config/baremetal/arm/entrypoints.txt b/libc/config/baremetal/arm/entrypoints.txt index 406f63f1df369..1cf3ee7eb87d1 100644 --- a/libc/config/baremetal/arm/entrypoints.txt +++ b/libc/config/baremetal/arm/entrypoints.txt @@ -462,6 +462,7 @@ set(TARGET_LIBM_ENTRYPOINTS libc.src.math.fminimum_magl libc.src.math.fminimum_num libc.src.math.fminimum_numf + libc.src.math.fminimum_numf128 libc.src.math.fminimum_numl libc.src.math.fminimumf libc.src.math.fminimumf128 @@ -776,7 +777,6 @@ if(LIBC_TYPES_HAS_NATIVE_FLOAT128) libc.src.math.fmaximum_magf128 libc.src.math.fminimum_mag_numf128 libc.src.math.fminimum_magf128 - libc.src.math.fminimum_numf128 libc.src.math.fmodf128 libc.src.math.fmulf128 libc.src.math.frexpf128 diff --git a/libc/config/baremetal/riscv/entrypoints.txt b/libc/config/baremetal/riscv/entrypoints.txt index 04918d70b69be..517ef54bb376e 100644 --- a/libc/config/baremetal/riscv/entrypoints.txt +++ b/libc/config/baremetal/riscv/entrypoints.txt @@ -458,6 +458,7 @@ set(TARGET_LIBM_ENTRYPOINTS libc.src.math.fminimum_magl libc.src.math.fminimum_num libc.src.math.fminimum_numf + libc.src.math.fminimum_numf128 libc.src.math.fminimum_numl libc.src.math.fminimumf libc.src.math.fminimumf128 @@ -773,7 +774,6 @@ if(LIBC_TYPES_HAS_NATIVE_FLOAT128) libc.src.math.fmaximum_magf128 libc.src.math.fminimum_mag_numf128 libc.src.math.fminimum_magf128 - libc.src.math.fminimum_numf128 # libc.src.math.fmodf128 libc.src.math.fmulf128 libc.src.math.frexpf128 diff --git a/libc/config/darwin/aarch64/entrypoints.txt b/libc/config/darwin/aarch64/entrypoints.txt index bad582299d3ad..6b0ddb3bc8d34 100644 --- a/libc/config/darwin/aarch64/entrypoints.txt +++ b/libc/config/darwin/aarch64/entrypoints.txt @@ -269,6 +269,7 @@ set(TARGET_LIBM_ENTRYPOINTS libc.src.math.fminimum_magl libc.src.math.fminimum_num libc.src.math.fminimum_numf + libc.src.math.fminimum_numf128 libc.src.math.fminimum_numl libc.src.math.fminimumf libc.src.math.fminimumf128 @@ -585,7 +586,6 @@ if(LIBC_TYPES_HAS_NATIVE_FLOAT128) libc.src.math.fmaximum_magf128 libc.src.math.fminimum_mag_numf128 libc.src.math.fminimum_magf128 - libc.src.math.fminimum_numf128 libc.src.math.fmodf128 libc.src.math.fmulf128 libc.src.math.frexpf128 diff --git a/libc/config/darwin/x86_64/entrypoints.txt b/libc/config/darwin/x86_64/entrypoints.txt index b22723eee2930..d11c03c550636 100644 --- a/libc/config/darwin/x86_64/entrypoints.txt +++ b/libc/config/darwin/x86_64/entrypoints.txt @@ -164,6 +164,7 @@ set(TARGET_LIBM_ENTRYPOINTS #libc.src.math.fmin #libc.src.math.fminf #libc.src.math.fminf128 + #libc.src.math.fminimum_numf128 #libc.src.math.fminimumf128 #libc.src.math.fminl #libc.src.math.fmod diff --git a/libc/config/freebsd/x86_64/entrypoints.txt b/libc/config/freebsd/x86_64/entrypoints.txt index 4a1e25b34ee81..246f35980c0fe 100644 --- a/libc/config/freebsd/x86_64/entrypoints.txt +++ b/libc/config/freebsd/x86_64/entrypoints.txt @@ -201,6 +201,7 @@ set(TARGET_LIBM_ENTRYPOINTS libc.src.math.fminimuml libc.src.math.fminimum_num libc.src.math.fminimum_numf + libc.src.math.fminimum_numf128 libc.src.math.fminimum_numl libc.src.math.fminimum_mag libc.src.math.fminimum_magf @@ -524,7 +525,6 @@ if(LIBC_TYPES_HAS_NATIVE_FLOAT128) libc.src.math.fmaximum_magf128 libc.src.math.fminimum_mag_numf128 libc.src.math.fminimum_magf128 - libc.src.math.fminimum_numf128 libc.src.math.fmodf128 libc.src.math.fmulf128 libc.src.math.frexpf128 diff --git a/libc/config/gpu/amdgpu/entrypoints.txt b/libc/config/gpu/amdgpu/entrypoints.txt index 65cfea121d886..6e7fbc51b7970 100644 --- a/libc/config/gpu/amdgpu/entrypoints.txt +++ b/libc/config/gpu/amdgpu/entrypoints.txt @@ -400,6 +400,7 @@ set(TARGET_LIBM_ENTRYPOINTS libc.src.math.fminimum_mag_numl libc.src.math.fminimum_num libc.src.math.fminimum_numf + libc.src.math.fminimum_numf128 libc.src.math.fminimum_numl libc.src.math.fminl libc.src.math.fmod diff --git a/libc/config/gpu/nvptx/entrypoints.txt b/libc/config/gpu/nvptx/entrypoints.txt index d4d6120c98edd..a00b6af787570 100644 --- a/libc/config/gpu/nvptx/entrypoints.txt +++ b/libc/config/gpu/nvptx/entrypoints.txt @@ -396,6 +396,7 @@ set(TARGET_LIBM_ENTRYPOINTS libc.src.math.fminimum_mag_numl libc.src.math.fminimum_num libc.src.math.fminimum_numf + libc.src.math.fminimum_numf128 libc.src.math.fminimum_numl libc.src.math.fminl libc.src.math.fmod diff --git a/libc/config/linux/aarch64/entrypoints.txt b/libc/config/linux/aarch64/entrypoints.txt index b885e26772d12..f418d0be0e98a 100644 --- a/libc/config/linux/aarch64/entrypoints.txt +++ b/libc/config/linux/aarch64/entrypoints.txt @@ -610,6 +610,7 @@ set(TARGET_LIBM_ENTRYPOINTS libc.src.math.fminimum_magl libc.src.math.fminimum_num libc.src.math.fminimum_numf + libc.src.math.fminimum_numf128 libc.src.math.fminimum_numl libc.src.math.fminimumf libc.src.math.fminimumf128 @@ -919,7 +920,6 @@ if(LIBC_TYPES_HAS_NATIVE_FLOAT128) libc.src.math.fmaximum_magf128 libc.src.math.fminimum_mag_numf128 libc.src.math.fminimum_magf128 - libc.src.math.fminimum_numf128 libc.src.math.fmodf128 libc.src.math.fmulf128 libc.src.math.frexpf128 diff --git a/libc/config/linux/arm/entrypoints.txt b/libc/config/linux/arm/entrypoints.txt index 46ed6df69f88a..2c303a5d57017 100644 --- a/libc/config/linux/arm/entrypoints.txt +++ b/libc/config/linux/arm/entrypoints.txt @@ -437,6 +437,7 @@ set(TARGET_LIBM_ENTRYPOINTS libc.src.math.fminimum_magl libc.src.math.fminimum_num libc.src.math.fminimum_numf + libc.src.math.fminimum_numf128 libc.src.math.fminimum_numl libc.src.math.fminimumf libc.src.math.fminimumf128 diff --git a/libc/config/linux/riscv/entrypoints.txt b/libc/config/linux/riscv/entrypoints.txt index cd4b74f432e8f..40c0dc5ef6145 100644 --- a/libc/config/linux/riscv/entrypoints.txt +++ b/libc/config/linux/riscv/entrypoints.txt @@ -678,6 +678,7 @@ set(TARGET_LIBM_ENTRYPOINTS libc.src.math.fminimum_magl libc.src.math.fminimum_num libc.src.math.fminimum_numf + libc.src.math.fminimum_numf128 libc.src.math.fminimum_numl libc.src.math.fminimumf libc.src.math.fminimumf128 @@ -1004,7 +1005,6 @@ if(LIBC_TYPES_HAS_NATIVE_FLOAT128) libc.src.math.fmaximum_magf128 libc.src.math.fminimum_mag_numf128 libc.src.math.fminimum_magf128 - libc.src.math.fminimum_numf128 libc.src.math.fmodf128 libc.src.math.fmulf128 libc.src.math.frexpf128 diff --git a/libc/config/linux/x86_64/entrypoints.txt b/libc/config/linux/x86_64/entrypoints.txt index 20ee66f70318d..975cfce1c5063 100644 --- a/libc/config/linux/x86_64/entrypoints.txt +++ b/libc/config/linux/x86_64/entrypoints.txt @@ -688,6 +688,7 @@ set(TARGET_LIBM_ENTRYPOINTS libc.src.math.fminimum_magl libc.src.math.fminimum_num libc.src.math.fminimum_numf + libc.src.math.fminimum_numf128 libc.src.math.fminimum_numl libc.src.math.fminimumf libc.src.math.fminimumf128 @@ -1014,7 +1015,6 @@ if(LIBC_TYPES_HAS_NATIVE_FLOAT128) libc.src.math.fmaximum_magf128 libc.src.math.fminimum_mag_numf128 libc.src.math.fminimum_magf128 - libc.src.math.fminimum_numf128 libc.src.math.fmodf128 libc.src.math.fmulf128 libc.src.math.frexpf128 diff --git a/libc/config/windows/entrypoints.txt b/libc/config/windows/entrypoints.txt index d4c25d9d5f074..5b58e787e7ecd 100644 --- a/libc/config/windows/entrypoints.txt +++ b/libc/config/windows/entrypoints.txt @@ -234,6 +234,7 @@ set(TARGET_LIBM_ENTRYPOINTS libc.src.math.fminimuml libc.src.math.fminimum_num libc.src.math.fminimum_numf + libc.src.math.fminimum_numf128 libc.src.math.fminimum_numl libc.src.math.fminimum_mag libc.src.math.fminimum_magf diff --git a/libc/shared/math/fminimum_numf128.h b/libc/shared/math/fminimum_numf128.h index dcacd52b18a12..e654f0025bdf6 100644 --- a/libc/shared/math/fminimum_numf128.h +++ b/libc/shared/math/fminimum_numf128.h @@ -9,10 +9,6 @@ #ifndef LLVM_LIBC_SHARED_MATH_FMINIMUM_NUMF128_H #define LLVM_LIBC_SHARED_MATH_FMINIMUM_NUMF128_H -#include "include/llvm-libc-types/float128.h" - -#ifdef LIBC_TYPES_HAS_NATIVE_FLOAT128 - #include "shared/libc_common.h" #include "src/__support/math/fminimum_numf128.h" @@ -24,6 +20,4 @@ using math::fminimum_numf128; } // namespace shared } // namespace LIBC_NAMESPACE_DECL -#endif // LIBC_TYPES_HAS_NATIVE_FLOAT128 - #endif // LLVM_LIBC_SHARED_MATH_FMINIMUM_NUMF128_H diff --git a/libc/src/__support/math/CMakeLists.txt b/libc/src/__support/math/CMakeLists.txt index 6d8fa6f32a95e..1ee179c4a5f31 100644 --- a/libc/src/__support/math/CMakeLists.txt +++ b/libc/src/__support/math/CMakeLists.txt @@ -1358,7 +1358,7 @@ add_header_library( HDRS fminimum_numf128.h DEPENDS - libc.include.llvm-libc-types.float128 + libc.src.__support.FPUtil.float128 libc.src.__support.FPUtil.basic_operations libc.src.__support.macros.config ) diff --git a/libc/src/__support/math/fminimum_numf128.h b/libc/src/__support/math/fminimum_numf128.h index 6f3ac894a7d2b..607eae7ee0e6b 100644 --- a/libc/src/__support/math/fminimum_numf128.h +++ b/libc/src/__support/math/fminimum_numf128.h @@ -9,23 +9,20 @@ #ifndef LLVM_LIBC_SRC___SUPPORT_MATH_FMINIMUM_NUMF128_H #define LLVM_LIBC_SRC___SUPPORT_MATH_FMINIMUM_NUMF128_H -#include "include/llvm-libc-types/float128.h" - -#ifdef LIBC_TYPES_HAS_NATIVE_FLOAT128 - #include "src/__support/FPUtil/BasicOperations.h" +#include "src/__support/FPUtil/float128.h" #include "src/__support/macros/config.h" namespace LIBC_NAMESPACE_DECL { namespace math { -LIBC_INLINE constexpr float128 fminimum_numf128(float128 x, float128 y) { +using LIBC_NAMESPACE::fputil::Float128; + +LIBC_INLINE constexpr Float128 fminimum_numf128(Float128 x, Float128 y) { return fputil::fminimum_num(x, y); } } // namespace math } // namespace LIBC_NAMESPACE_DECL -#endif // LIBC_TYPES_HAS_NATIVE_FLOAT128 - #endif // LLVM_LIBC_SRC___SUPPORT_MATH_FMINIMUM_NUMF128_H diff --git a/libc/src/math/fminimum_numf128.h b/libc/src/math/fminimum_numf128.h index 1833e9e1c9f5c..3b02a6519e037 100644 --- a/libc/src/math/fminimum_numf128.h +++ b/libc/src/math/fminimum_numf128.h @@ -10,11 +10,16 @@ #ifndef LLVM_LIBC_SRC_MATH_FMINIMUM_NUMF128_H #define LLVM_LIBC_SRC_MATH_FMINIMUM_NUMF128_H +#include "src/__support/FPUtil/float128.h" #include "src/__support/macros/config.h" #include "src/__support/macros/properties/types.h" namespace LIBC_NAMESPACE_DECL { +#ifndef LIBC_TYPES_HAS_NATIVE_FLOAT128 +using float128 = LIBC_NAMESPACE::fputil::Float128; +#endif // LIBC_TYPES_HAS_NATIVE_FLOAT128 + float128 fminimum_numf128(float128 x, float128 y); } // namespace LIBC_NAMESPACE_DECL diff --git a/libc/src/math/generic/CMakeLists.txt b/libc/src/math/generic/CMakeLists.txt index fe0fbe51eadac..b12b73c900abc 100644 --- a/libc/src/math/generic/CMakeLists.txt +++ b/libc/src/math/generic/CMakeLists.txt @@ -2474,6 +2474,7 @@ add_entrypoint_object( HDRS ../fminimum_numf128.h DEPENDS + libc.src.__support.CPP.bit libc.src.__support.math.fminimum_numf128 ) diff --git a/libc/src/math/generic/fminimum_numf128.cpp b/libc/src/math/generic/fminimum_numf128.cpp index fec526cd19c41..793d3e6041a52 100644 --- a/libc/src/math/generic/fminimum_numf128.cpp +++ b/libc/src/math/generic/fminimum_numf128.cpp @@ -7,12 +7,16 @@ //===----------------------------------------------------------------------===// #include "src/math/fminimum_numf128.h" +#include "src/__support/CPP/bit.h" #include "src/__support/math/fminimum_numf128.h" namespace LIBC_NAMESPACE_DECL { +using LIBC_NAMESPACE::fputil::Float128; + LLVM_LIBC_FUNCTION(float128, fminimum_numf128, (float128 x, float128 y)) { - return math::fminimum_numf128(x, y); + return cpp::bit_cast<float128>(math::fminimum_numf128( + cpp::bit_cast<Float128>(x), cpp::bit_cast<Float128>(y))); } } // namespace LIBC_NAMESPACE_DECL diff --git a/libc/test/shared/shared_math_constexpr_test.cpp b/libc/test/shared/shared_math_constexpr_test.cpp index cf0b878cbb3f5..e5bf228543221 100644 --- a/libc/test/shared/shared_math_constexpr_test.cpp +++ b/libc/test/shared/shared_math_constexpr_test.cpp @@ -401,6 +401,9 @@ static_assert(Float128(0.0) == static_assert(Float128(0.0) == LIBC_NAMESPACE::shared::fmaximum_numf128(Float128(0.0), Float128(0.0))); +static_assert(Float128(0.0) == + LIBC_NAMESPACE::shared::fminimum_numf128(Float128(0.0), + Float128(0.0))); static_assert(0LL == LIBC_NAMESPACE::shared::llrintf128(Float128(0.0))); static_assert(0LL == LIBC_NAMESPACE::shared::llroundf128(Float128(0.0))); static_assert(0L == LIBC_NAMESPACE::shared::lrintf128(Float128(0.0))); @@ -437,9 +440,6 @@ static_assert(float128(1.0) == static_assert(0.0f == LIBC_NAMESPACE::shared::fdivf128(float128(0.0), float128(1.0))); static_assert(0.0 == LIBC_NAMESPACE::shared::dsqrtf128(float128(0.0))); -static_assert(float128(0.0) == - LIBC_NAMESPACE::shared::fminimum_numf128(float128(0.0), - float128(0.0))); static_assert(float128(0.0) == LIBC_NAMESPACE::shared::fromfpf128(float128(0.0), 0, 32)); diff --git a/libc/test/shared/shared_math_test.cpp b/libc/test/shared/shared_math_test.cpp index 8584839093fe2..05cdd06049b2c 100644 --- a/libc/test/shared/shared_math_test.cpp +++ b/libc/test/shared/shared_math_test.cpp @@ -598,6 +598,8 @@ TEST(LlvmLibcSharedMathTest, AllEmuFloat128) { Float128(0.0), Float128(0.0))); EXPECT_FP_EQ(Float128(0.0), LIBC_NAMESPACE::shared::fmaximum_numf128( Float128(0.0), Float128(0.0))); + EXPECT_FP_EQ(Float128(0.0), LIBC_NAMESPACE::shared::fminimum_numf128( + Float128(0.0), Float128(0.0))); EXPECT_EQ(0LL, LIBC_NAMESPACE::shared::llrintf128(Float128(0.0))); EXPECT_EQ(0LL, LIBC_NAMESPACE::shared::llroundf128(Float128(0.0))); EXPECT_EQ(0L, LIBC_NAMESPACE::shared::lrintf128(Float128(0.0))); @@ -705,8 +707,6 @@ TEST(LlvmLibcSharedMathTest, AllFloat128) { 0.0f16, LIBC_NAMESPACE::shared::f16subf128(float128(0.0), float128(0.0))); EXPECT_FP_EQ(0.0f16, LIBC_NAMESPACE::shared::f16sqrtf128(float128(0.0))); #endif // LIBC_TYPES_HAS_FLOAT16 - EXPECT_FP_EQ(float128(0.0), LIBC_NAMESPACE::shared::fminimum_numf128( - float128(0.0), float128(0.0))); EXPECT_FP_EQ(float128(0.0), LIBC_NAMESPACE::shared::fromfpf128(float128(0.0), 0, 32)); EXPECT_FP_EQ(float128(0.0), diff --git a/libc/test/src/math/smoke/CMakeLists.txt b/libc/test/src/math/smoke/CMakeLists.txt index 00fdc71ca604b..4d41d1cf25f81 100644 --- a/libc/test/src/math/smoke/CMakeLists.txt +++ b/libc/test/src/math/smoke/CMakeLists.txt @@ -3323,6 +3323,7 @@ add_fp_unittest( HDRS FMinimumNumTest.h DEPENDS + libc.src.__support.FPUtil.float128 libc.src.math.fminimum_numf128 libc.src.__support.CPP.algorithm libc.src.__support.FPUtil.fp_bits diff --git a/libc/test/src/math/smoke/FMinimumNumTest.h b/libc/test/src/math/smoke/FMinimumNumTest.h index 10b7d7aab9343..bad31b0c647f7 100644 --- a/libc/test/src/math/smoke/FMinimumNumTest.h +++ b/libc/test/src/math/smoke/FMinimumNumTest.h @@ -80,7 +80,7 @@ class FMinimumNumTest : public LIBC_NAMESPACE::testing::FEnvSafeTest { continue; T x = xbits.get_val(); T y = ybits.get_val(); - if ((x == 0) && (y == 0)) + if ((x == T(0)) && (y == T(0))) continue; if (x > y) diff --git a/libc/test/src/math/smoke/fminimum_numf128_test.cpp b/libc/test/src/math/smoke/fminimum_numf128_test.cpp index d773d8973286e..863e177b06cbe 100644 --- a/libc/test/src/math/smoke/fminimum_numf128_test.cpp +++ b/libc/test/src/math/smoke/fminimum_numf128_test.cpp @@ -7,7 +7,12 @@ //===----------------------------------------------------------------------===// #include "FMinimumNumTest.h" +#include "src/__support/FPUtil/float128.h" #include "src/math/fminimum_numf128.h" +#ifndef LIBC_TYPES_HAS_NATIVE_FLOAT128 +using float128 = LIBC_NAMESPACE::fputil::Float128; +#endif // LIBC_TYPES_HAS_NATIVE_FLOAT128 + LIST_FMINIMUM_NUM_TESTS(float128, LIBC_NAMESPACE::fminimum_numf128) diff --git a/utils/bazel/llvm-project-overlay/libc/BUILD.bazel b/utils/bazel/llvm-project-overlay/libc/BUILD.bazel index 2b7cb92d195bd..83db1d3cb235d 100644 --- a/utils/bazel/llvm-project-overlay/libc/BUILD.bazel +++ b/utils/bazel/llvm-project-overlay/libc/BUILD.bazel @@ -5872,8 +5872,8 @@ libc_support_library( hdrs = ["src/__support/math/fminimum_numf128.h"], deps = [ ":__support_fputil_basic_operations", + ":__support_fputil_float128", ":__support_macros_config", - ":llvm_libc_types_float128", ], ) @@ -12125,6 +12125,8 @@ libc_math_function( libc_math_function( name = "fminimum_numf128", additional_deps = [ + ":__support_cpp_bit", + ":__support_fputil_float128", ":__support_math_fminimum_numf128", ], ) diff --git a/utils/bazel/llvm-project-overlay/libc/test/src/math/smoke/BUILD.bazel b/utils/bazel/llvm-project-overlay/libc/test/src/math/smoke/BUILD.bazel index 4b8657372f094..cb9fff7e83fc3 100644 --- a/utils/bazel/llvm-project-overlay/libc/test/src/math/smoke/BUILD.bazel +++ b/utils/bazel/llvm-project-overlay/libc/test/src/math/smoke/BUILD.bazel @@ -773,6 +773,9 @@ math_test( math_test( name = "fminimum_numf128", hdrs = ["FMinimumNumTest.h"], + deps = [ + "//libc:__support_fputil_float128", + ], ) math_test( _______________________________________________ llvm-branch-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
