RiverDave wrote: > Should we also fix the cases > [here](https://github.com/llvm/llvm-project/blob/46f2d1cb349b8baffa3e8c657e06ccb4ae068ddc/clang/lib/CIR/Dialect/Transforms/TargetLowering/CIRABIRewriteContext.cpp#L679) > + L719 and L1502.
It looks like those cases run under the CallConvLowering pass. I think we should defer these until later given That pass currently only runs for x86 which has default AS. IIRC The ABI library for AMDGPU is currently in the works (see: https://github.com/llvm/llvm-project/issues/220471) so we won't have tests to run this on targets with non-default AS to exercise these changes. thoughts? https://github.com/llvm/llvm-project/pull/226650 _______________________________________________ llvm-branch-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
