llvmorg-github-actions[bot] wrote:
<!--LLVM PR SUMMARY COMMENT--> @llvm/pr-subscribers-mlir Author: Hideto Ueno (uenoku) <details> <summary>Changes</summary> Under EXPENSIVE_CHECKS, compare operation fingerprints before and after greedy rewriting. If the IR changes but the driver reports no change, emit a fatal error. For now EXPENSIVE_CHECKS is used. I considered using MLIR_ENABLE_EXPENSIVE_PATTERN_API_CHECKS but I thought it's better to keep it to validate pattern APIs. Assisted-by: gpt 6.1 sol --- Full diff: https://github.com/llvm/llvm-project/pull/232576.diff 1 Files Affected: - (modified) mlir/lib/Transforms/Utils/GreedyPatternRewriteDriver.cpp (+28) ``````````diff diff --git a/mlir/lib/Transforms/Utils/GreedyPatternRewriteDriver.cpp b/mlir/lib/Transforms/Utils/GreedyPatternRewriteDriver.cpp index de800cb14af9c..1edb09d1738bb 100644 --- a/mlir/lib/Transforms/Utils/GreedyPatternRewriteDriver.cpp +++ b/mlir/lib/Transforms/Utils/GreedyPatternRewriteDriver.cpp @@ -954,10 +954,23 @@ mlir::applyPatternsGreedily(Region ®ion, "greedy pattern rewriter input IR failed to verify"); #endif // MLIR_ENABLE_EXPENSIVE_PATTERN_API_CHECKS +#ifdef EXPENSIVE_CHECKS + OperationFingerPrint before(config.getScope()->getParentOp()); + bool rewriteChanged = false; + if (!changed) + changed = &rewriteChanged; +#endif // EXPENSIVE_CHECKS + // Start the pattern driver. RegionPatternRewriteDriver driver(region.getContext(), patterns, config, region); LogicalResult converged = std::move(driver).simplify(changed); +#ifdef EXPENSIVE_CHECKS + if (!*changed && + before != OperationFingerPrint(config.getScope()->getParentOp())) + llvm::report_fatal_error( + "greedy pattern rewriter changed IR but did not report a change"); +#endif // EXPENSIVE_CHECKS if (failed(converged)) LDBG() << "The pattern rewrite did not converge after scanning " << config.getMaxIterations() << " times"; @@ -1084,12 +1097,27 @@ LogicalResult mlir::applyOpPatternsGreedily( "greedy pattern rewriter input IR failed to verify"); #endif // MLIR_ENABLE_EXPENSIVE_PATTERN_API_CHECKS +#ifdef EXPENSIVE_CHECKS + std::optional<OperationFingerPrint> before; + if (config.getScope()) + before.emplace(config.getScope()->getParentOp()); + bool rewriteChanged = false; + if (!changed) + changed = &rewriteChanged; +#endif // EXPENSIVE_CHECKS + // Start the pattern driver. llvm::SmallDenseSet<Operation *, 4> surviving; MultiOpPatternRewriteDriver driver(ops.front()->getContext(), patterns, config, ops, allErased ? &surviving : nullptr); LogicalResult converged = std::move(driver).simplify(ops, changed); +#ifdef EXPENSIVE_CHECKS + if (!*changed && before && + *before != OperationFingerPrint(config.getScope()->getParentOp())) + llvm::report_fatal_error( + "greedy pattern rewriter changed IR but did not report a change"); +#endif // EXPENSIVE_CHECKS if (allErased) *allErased = surviving.empty(); if (failed(converged)) `````````` </details> https://github.com/llvm/llvm-project/pull/232576 _______________________________________________ llvm-branch-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
