https://github.com/cyndyishida commented:

> If we have -fmodule-file should we take modulemap mentioned in this .pcm file 
> or should we resolve it through the header search?

I think we should actually skip over those modules in the resulting map. I 
don't think scan should try to reason which one is preferred. In a normal scan, 
we just consume the prebuilt module as a dependency unconditionally. 

I missed this case. Not sure how this manifests in a Swift incremental scan 
cache, but I'm fixing it in clang regardless. 


https://github.com/llvm/llvm-project/pull/235845
_______________________________________________
llvm-branch-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

Reply via email to