https://github.com/ftynse commented:

Good idea in general, thanks for working on it!

High-level questions: 

1. Why don't we just split the \*Ops.td file in the first place? I know 
tablegen itself is not on the compilation path, but may be more consistent 
between files and easier on ODS magic.
2. Should we deprecate and remove the existing sharding mechanism? It shouldn't 
be hard to transition by simply introducing "shard 1" and "shard 2" for 
dialects that don't want to bother with grouping operations semantically.

One bikeshed: "natural sharding" screamed at me as "it's automatic", something 
like "component sharding", "logical sharding", or even "user-defined sharding".

One proposal: since we are introducing what is essentially a semantic grouping 
of operations, it may be nice to leverage it to also organize the generated 
documentation by groups, like LLVM IR LangRef does.

I didn't do a detailed review, let's see there is consensus on the direction 
first.

https://github.com/llvm/llvm-project/pull/239254
_______________________________________________
llvm-branch-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

Reply via email to