| Issue |
240688
|
| Summary |
[Driver][CFI] collectSanitizerRuntimes Suppresses libclang_rt.cfi.a and libclang_rt.cfi_diag.a When Combined with Shared UBSan Runtime (-fsanitize=cfi,undefined -fsanitize-cfi-cross-dso -shared-libsan)
|
| Labels |
new issue
|
| Assignees |
|
| Reporter |
zjy-dev
|
In `collectSanitizerRuntimes` (clang/lib/Driver/ToolChains/CommonArgs.cpp:1745-1750), adding `"cfi"` (`libclang_rt.cfi.a`) and `"cfi_diag"` (`libclang_rt.cfi_diag.a`) to `StaticRuntimes` is wrapped inside `if (!(SanArgs.needsSharedRt() && SanArgs.needsUbsanRt()))`. However, `libclang_rt.ubsan_standalone.so` (added to `SharedRuntimes` when `SanArgs.needsSharedRt() && SanArgs.needsUbsanRt()` is true) does NOT contain the Cross-DSO CFI runtime (`__cfi_slowpath`, `__cfi_slowpath_diag`, `__cfi_init`). Consequently, when a user links with `-fsanitize=cfi,undefined -fsanitize-cfi-cross-dso -shared-libsan` (or on targets like Android where `needsSharedRt()` defaults to true), `needsUbsanRt()` is true (for `undefined`) and `needsCfiCrossDsoRt()` is true (for `cfi`), yet the guard suppresses `libclang_rt.cfi.a` / `libclang_rt.cfi_diag.a`, resulting in link-time `undefined symbol: __cfi_slowpath` errors.
### Reproducer (`trigger.cpp`)
```cpp
struct A { virtual void f(); virtual ~A() {} };
struct B : A { void f() override; };
void B::f() {}
void A::f() {}
void caller(A *a) { a->f(); }
int main() {
B b;
caller(&b);
return 0;
}
```
Compile / reproduction command (`['--target=x86_64-unknown-linux-gnu', '-flto', '-fvisibility=default', '-fsanitize=cfi,undefined', '-fsanitize-cfi-cross-dso', '-shared-libsan', '-###']`):
```bash
podman exec -i -e TMPDIR=/dev/shm defuzz-toolchain-daemon /opt/llvm23/bin/clang++ --target=x86_64-unknown-linux-gnu -flto -fvisibility=default -fsanitize=cfi,undefined -fsanitize-cfi-cross-dso -shared-libsan -### -x c++ -
```
Observed output on LLVM 23.1.2:
```text
"/usr/bin/ld" ... "--whole-archive" "/opt/llvm23/lib/clang/23/lib/x86_64-unknown-linux-gnu/libclang_rt.ubsan_standalone.so" "--no-whole-archive" ... "--export-dynamic-symbol=__cfi_check" (libclang_rt.cfi.a and libclang_rt.cfi_diag.a are completely omitted!)
```
### Expected behavior
`collectSanitizerRuntimes` in `CommonArgs.cpp:1745-1750` must still link the static `cfi` / `cfi_diag` runtime when `SanArgs.needsCfiCrossDsoRt()` is true, because no shared Cross-DSO CFI runtime exists in `libclang_rt.ubsan_standalone.so`.
### Root cause & impact
- **Source location**: `clang/lib/Driver/ToolChains/CommonArgs.cpp:1745-1750`
- **Impact**: Prevents linking any program or shared library that combines Cross-DSO CFI (`-fsanitize=cfi -fsanitize-cfi-cross-dso`) with UBSan (`-fsanitize=undefined`) and `-shared-libsan`.
### Suggested fix
Remove the `if (!(SanArgs.needsSharedRt() && SanArgs.needsUbsanRt()))` wrapper around `if (SanArgs.needsCfiCrossDsoRt()) StaticRuntimes.push_back("cfi");` in `clang/lib/Driver/ToolChains/CommonArgs.cpp:1745-1750` (or link `cfi` whenever no shared CFI runtime is added).
Environment: LLVM 23.1.2 (`llvmorg-23.1.2`), affected targets: `x86_64, aarch64, riscv64, loongarch64`.
_______________________________________________
llvm-bugs mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-bugs