Issue 241316
Summary [PGO][ICP] clang asserts in isLegalToPromote when a value profile redirects an indirect call to an incompatible vararg function
Labels clang
Assignees
Reporter cactusBalll
    **Generated by Fuzzer.** Compiling with `-fprofile-instr-use=<profdata>` aborts in
`llvm::isLegalToPromote()` when the indirect-call value profile redirects a call site to a
vararg function whose fixed parameter count is greater than the call site's actual argument
count. `isLegalToPromote()` only rejects an arity mismatch for non-vararg callees; for a vararg
callee it loops to `NumParams` and indexes `CB.getArgOperand(I)`, which can be past
`CB.arg_size()`.

## Environment

- clang `24.0.0git`, commit `0db002877564df53575e997e985538a949a03327`
- build config `+assertions,+asan,+ubsan`, `x86_64-unknown-linux-gnu`

## Reproduction

The reproducer consists of `prog_0.c`, `prog.h`, and the corrupted `mut.profdata`. Save the
following self-contained archive and extract it:

```bash
base64 -d > repro.tar.gz <<'EOF'
H4sIAAAAAAAAA+09bYwkR3VrY2Pf2ncO+A+xCSl2dUfPfvbXfO3srn23d3An7vaO21tz8vnc7pnp
2WnfTPfQ3bO3Z98GJ0rAAkVCQo6InB+AQE5MSIyEhVAUQZASgQiJrCiOiEMESQgRshIUFIxQgvOq
uqq7uqd7umd37xyULZ22u169evXeq1evXn30XM+xNzRxrjF2A5MIqaSq+CmViyL/hCSrqqKMSUW5
rJYUtSwCniTjBxJvJFMs9V1PdxAa61tN3eu7JSUNL6P8FzRNmlaj028aaKIHljDXnhgf37Q7umd2
DGRaniJrHup2TVtzjA0RLSG5UlIUSSoqtXQ8CfCKZblUkhWxNARPBrxKsVKtKmqxWhvXNECQ5AoC
g4QSkavZ6ti6B3BMWZortmrjfUas0TYaV9x+V3NN64pfDZeVVCjrbdgceIAPXPyE4dha3YbeDesG
ha5hNLVNvdM3cOGWpBTL1Xqz1a+NMyxhCuO1epqn1zvGpcrlglAA3CdJdW/D08SZ4FUKX+XwVQlf
1fC1GL6Wwtcy2o437elmJ2y/CO3Tco4NjML4wO8S9y5z7wr3ruKmxuenMGSubYD2l9BJ25tBDb3T
0a4a5kYbgyRRRFPzAU+tvtXQJCHQoVgYR5CeJH9x6ono+hICo+AAj0YAIS5OQXds6o2GpmKLEfu1
FBSzuaWpSgJKy3aQEKJpqkQ6Gwn++yIqyoVaUECh00gqFGLsDDLIUti40HC7ptfWsCrbpidUxX4B
PQA8oQUkSH2gK8Rs6zAq9wuFQi2ZMBUctCREbI22iC1usOb2eHouGBVAklIPCYSoEaWZm5qqUqX5
74tILoLSWAGFJiltUGGxXi0ldFkUjYhaTkEb6N0i17tF3LsK7d0i691iau8mM8xSyMge9zIhTpWR
0tPl5J7GaTuj/3Ea7PVSLcVItlMGY8R/e92eplZ8p8kjRQuDqSOKpGm6Z3fNhua1HUNvai3DahiC
ph29cPbMqRVt7cT7tJW1C4VhlIWo478O/ZlkxckSbOpYA0VxkP0QwzU6WlEaxIiamw7WVGX25mcW
UYm4E1bE4CM6lJCBuK2Vqa0RU0u0NCXV0NyrptdoY5588mljAKcG4CBxYQhGyCzVJxgXZmZTd3QH
pnFBHGLvLNXBBK6kow2acs6KhH1pV+zDTBlX7nTQn1O4P99o+eRdySdnyjccQX7jFaDsSgHK7hUw
HCF9JN5oDWVNCsOCAl9bSf6U+Q8I7WJ6H94b6X0UzCoeaVUZ9LjJ2JtaUR2OG/HUXc/UijL11DQD
MQwODYIiBh8WHGQLxFLAYoJ90IamUDmPeZitxHgji8WQEapZav3+gkAQKINH8jGxjYwO9PDoTQqD
65SUaUstFCDIGZWvoRjppekl/FhgguQdYzglDMooYgICGT2ltNHDcxSNDQftgoUGpUJ6wLhjDqv/
5zmUUgOWdMsNFhqurhWLl6rFy8HimbPP7XRbDAnUtWIpIBC38EeRLKuliiwXRVgL5CMIxlcOCMLy
IlclYrPVlPUSSxH36II/qlDv6L8voipe4LECCt0b1+jrmVC8nOwg/dZg/uzn8QG+2lPpPRrItIik
TII7cRlRXXpaCS8tJKxL8g66VLEuaQGFTuPwYfe6JBZCKBLZBV+5tI1Z6K/L0BLVOMEqEAXzWNMU
S6CK9IlNx0ZArlCG2R74AZ6zvVc573FoozfFSUupIXcOB9PAjJakjJGJ53tNq/fNjmdamrHVMxpe
3I1KEHiKe2A+jCMaG4S9nd3VrOr0EioPkSaOPrUEozo/OjCmlJViVa4Ui9XR6mGBGnanCcHOzsd8
nrAnv5qnd65mKlDb9nYlT64BRdu8kQMqLNQ03e1qGjzZFj1khIkt8KmHDxv61oz/eMQ6cKDR65vN
CYgd/H8TAJ6YgUfdfzT8R5M8ukbXdq5NcJpyDK/vWOAicQKFhttTBS4j8RkZZ2CliB+RHScMYBqj
TWyPvmHOOlQSNm2zGd8tZ1i4M2QyoQRFPgiPjQSYnABTuT13rqNJ+YCGOOguhFIyhVIHhVIxV8UE
mDwcFhdKTRRKDYRaWTtz6sJJbfXsqdXTp1ZPRA6FyMHNUObJqkCKsR8JAmCBJ7GNaP8dVpsQAzA4
BSbFU4z4NIelJO5u8kLTWgNiR+A5BJdzCI4DQmWI4FVOcLwhqlLBq0zw5N1QRnyawyrmFLySIngl
t+BqtuAyHoXFdMFlJRQc3hdhiVML4BSYKjgQn+awyvkElwdHbwSeQ/BSDsHxGU15iOBlTvAyCF6h
gpeZ4OUhgpcCwTFWNafgpRTBS/kdV4X4raH68fdKGGhrqJYUEtxvxYZrgsSACBJvJcmJYz8gsZwQ
3FE+z6yvXbhw9NRpJnV4rosr4oA/nwIVMVmBDL6HCpTzKlBmCixmKFC+EQpURlRgytBTRpg6cypQ
zatAlSmwnKFANVWBg3KmTCqKml/OUqacdE8+vD1gzaC5ubm4uJu61jFdCB96msL5/MiJslKNbgxD
HXzLxxNIpRlkFVI8GT4bFrnTY7xyt+jhscgOj8VET8Yansb75xpIwhpj9zGSVA2YhtX0MTmEgbNa
pTrQAxH4Nr61YzYRXSM27G6v7xlaW3fbvm+nzHqObrk93TEsT2s4DUFgV2UKQSSMA2f2PoGXmLWc
NSWupjRSTZmrKeequYHvs0zA33RsrX7NM1y/TkXzpgpHNvDFF9zVBdd8wrBbAgAKhEw+diPhP9SL
5HNRYP0Kldlr7nrhRSVaOwTkbztYdTIOAgClAYYEFVBXN62I4fRgXQYjpavhEq1ubEA5bRKaAfve
gBb1OoOxQeU7MAfXMf1hxQMgII4Apqf5QRXZUQ7EoDeMlGDJRVhIMHuKEGUcDzaf34ZtecaWB4s4
cevdNK2fDhVJR5mIVTI/NX7x4kWElYUqVblckYslUSK3FGVVLZJC252DRSySWIbYs+00DQcq+VDs
IMluRMuKQ3q610ZKAMOLJ4wkRSAd2+5xFU2raTpGA/oZHC2SAzhG07r9jmcaW6bHVSAFrmdYDbPD
gbt918NzDAdyrxhXwTDqYEyNNgcnlqL1HLuFr9HJyXCtZ3euRQqxX3cpGdfreqAp19ywKA6B1Dt2
4wqPgvvHtPoGD2va2tV22DKBYUvjsjD5cxVoJ3IQenzpQ7AteaZtuUj2ARsdu653XKx4mKze6KuZ
NyX5tz5vbBsZ93+LclGK3/9Vy9L+/d+bkcC3oSnqQGcdF4EfNxzdA6cFg79pd9EKwibi6F2MtwYu
cCHRB0Lhim21zI0FVNcbV8DRLm1VSlpJJaPMXZIl1LWb/Y4Br2RzbclzYHSDz/RfmBfyc9Rn+Bm6
nbSkkjfqZZbMRg/VTd1dqoq48WN+owvIbxWDzhuA2+w3jIUE+dDsbKo/x5HqpNmymkaLLRnOr2lr
506fuqAl4GsnxycB1bSMnNgQLM9CQka3bjSbRpNjz+mD2+safjmwkcDHyskTK+9dWz+T2CxfyG52
L7peE6bPufZyDGZj0DjYv2c2uCMKMj/CZH4JGL9cSyln8+dSZP4MsMnc78BfMhmHd6hrQXt+vMrH
DmG80bfw/ACKMWfQ43g+9uMJP4IgcUOxBC9hvMAzB1gmF4U87td6HO9JwAPq0AjDR8XhADoC8Tx6
AAni1onjxyoVRRbXT+NDQ1y2vEyC/QUux8c9WE8mPneDLIZv4xBqUEQcjLJQFNV9tuOKDAkOxChQ
4whR9GXKFlcKLFX8yG2w2YofBAcX4qEf+LYJV4ytgoBLiXBppX5bmShSKRtHVrNxFDkbRxVz4OTg
uUh4jikxHk3zeoQFbhsmjqlNS+8aZJWHWh19g1cv1T5WK24eb0wQFD8wxaOjJUwcdtHhTmfrEQsi
cEpLCOy/Y1sb5E/BJzKcPy3sbWxmUz3P8RmzSMFQjnHOTBpqfl1/tHF2T7QIDYDxDxeOVL90uHmZ
l9AnOihQ0jKDuoXtIYg4rOddQFw4nwbOY1YZc2z9BrIevki4CxRfACI+d/NTSasLZLrI971NEBB5
bYObOOl8ifSWZzgsppzD3nz4Gh184yRIYrbGk9z+WZhT1s+dO3v+QqLjjxQH1Y+urJxYg8LVlRNB
HQ4mbBWQMCUEH8Z413p4XQxQWC7Do8AYYvTOnzh6PEotgOBaUdKBNFCbaUvQNH+C1rQCun6dA5sK
wLVCOIF0MHleY+2rWl13HNNwmE0knhwKE11ynXwCLSwscKeA4JonjU6EFV13Gm3Cy1402+zWwS7a
edoFw70JbbrGqE2412B1jf+0HdsynzAESor2Y7p1rh199wntzFHIJAZDfGlCWBIQXF/FqHEKpPrx
Uw9pD584f5bYLP6zBC6K3YLnTBXTSiBFaJDoSDt6/Ligz+A5VaRaykTyKUeVGV62ahma3oRlPd6a
oFDN1dxgV1EPNgH9qT/KYXg+iaZRvUZZIh6ZzDUO+bqGbn9gnCBTZ47XQcvo1OoFaOHM0Yt4WDng
uCng1GqB28wIz8DZtqRTY/JtDxPQ7df3QMDZHALOvjECdvudPRBwKoeAU2+MgE1zM7+APld1Msii
rWO4juEBd+jIEUQwZ6VERnU0j7UyXPv2CONnb5k7nMRcP3l0M7DW1/phxAH89WMMRof0cOrB0Bqd
+mw29cCuR6c+lU09MKpRqdd5/51iIf1kE9llU4n9zYbqgDPHUGaMBMM3RvLKGSNY4zLQB2PT/ZEM
CHgkz2IkGM5QvsjKF1k5WCcuT7HLRMuJ8Mn75Px8LibxOR3yuZzE53Q6n4k2GOGTd605+dTRO5d8
PghHIaPz0CLwWY9wB8A07hJtOMId7xdzcpfleihbO/aLnOrskU1xr5hL9YsJA4WBgyHJ+OvzDEZt
Gw2nHfGKo9CezaYd8Ymj0J7Kph3xiPlpJ/jDLCHsHSk/wRsifMSFKvNSabZuegt4Adu1PVgO2mQd
LdCFS2EGL3QtZMGywb5KNkkT4vTVo+fPn32/sD6DVo+eOTGDzp4roEdigqz7EkxOYpTJSV+Mycl1
eMUyrGPm132uH6F7EySGIoe3egFo0vc6rE8e4UKidQiGALA9hDNtTVgbxttaMm9r8IrH3hrmbW0n
vK0x3hK0RbdsZhCMqBk0XRiKAyNjBs0OxwELn4FFfBqOVMrRmI+U0ZqPlN4cqDtbNg4pvTkOKau5
LPF4rKwGowIODshK4sCvcMOxEo7GysBgfACFW5Fk2OOtZjF57FcSh/4Omzo8tCksdYJYGBw0RnBo
a+Q9sTlcki1a2F5Etl20ly5fYqdRRdLptRLMrnE1wvQKM+c7/dl0Fv9aDTeRkkOEPL2Z2Jk3goWh
WkjoZKZzygRTeZLGo2wocrmUyEh2/yd3/43jJF0n/s8MRUMbAtNaWkvwS4EH/4WGXH4GTwE0ZA89
Pl7UK3OqoVRabEk/S/PkE8g5sQV8OINRFsdHEAaNwsfs3vMRhEyj8DG193wElprFRxgKA9kwxIVM
dgjetPv1jhEzBB+oNbWmQMuhSfpG26S5VGOQ5sqGIlYC4WmeCp8sO89LYAyj8pJgELvlJTCIUXlJ
MIrd8hIYRQ5eeLvgzSLJKoZseJ97z9mh5zGx8mGb3rFLsbHjkvesrq8MHJY0Orq1gY8QYg0HF2vx
D+x4jlnHJ0yaIFi2rzWyTc7veA+0Tc97qOCwLFjBTSFJmUaG1bKdhuGCfhxD7yByaQxfPqshGxYG
DsJHWmbHcFxkbli2Y5BzsYAPfCVDt5rI9cxOh+ESFFfvwh+7D8QRsBrcBUEbfd3RLc8wCnMJdzLY
Ne6YwtJ0E9z6jumGtZamm7CZqG6C40h6eBYeQIYfamIcdu9hHt9IwfblIomcshpbesPrXEOP9QyQ
3PIeQ3bfQ3YLGZuGc418VIW1686hcz4Cctt2v9NEdaJL04JxM1etguaIFrFGdcd0bQuqWZYNnhA8
p93BF0yANRu6rWFbwBGYH9bmwCSMYl+Yhj+F5zdPj7YHpRMGYNP4M2uYaEGGPjewBvAWGW1y1hqe
4OS6uRIB6c4Gvc3i9BseWisViyo72CZCtLAfkci3IWxZ3CLfbgVituRIoXKpcpkCcATWUmmGhB+t
Yo2nXYrkyhE6lWgj1UuqBHS3awGraglc35N8FZGUD/lVvdrAt3YiO0OOF0hpBXJagcIKht3Wp5/V
5sDkPqbLRpTyIsp5EXNJw33+lY1YzItYyotYzoUY/xIpB7o0Gro8GroyGrqaGz34eSYGpJ+C5Ko1
8AEJjCRjyzPwNxOpv2xay0SRslHkAIX/KdPBesGvmQZFyb9mGimO/KBpOi/RLwMGG4h/fE7LWXHS
75mmIKX/8mgt86KL7+kRDi/y3JhE/19uY9/81O17c/hKbVP39BvVxvD732JZVMTY/W+lVFb273/f
jPR6h1yo/vVDfvaWePlP74rm7zwUzf8Szb+Z5enzbfR5nD7b90afXzzgP79Wo/XeFS1njHzyQ7ck
wh88+KZE+Hc/flsi/Kn7fA4fpo7kVgpHn7ojws+bKPyr7zqQCH/sjyiBO/3HbRQ+Vrw7Arid8f8n
B8lzihJgevrRr0U1TpsZE++/hzyXaf4gfV5cvifS3lvp8x+O3hOR8+30WTqWDH8gBX7L2J/9xedf
He+cfI1xUqHPIEg5+VvVX1l+/sCtTHVZ6c6A9Ic2D//BBWH+fqqisQc50myu//YfP/dl85J7B1P0
8lg0Xc9s5cO9l41/+dFfbwSq5FohAe/rr7/+H38zfmZ8wMhTSX7zAx98/a/u/sl32exzkiPph0C3
P33m799y948DpWTRfhuHw+PeMnbmtb+8/8VjLz+bpn9l5/o/9NBLj33608/OnKMQppn5prE577a7
89DGbKv/xBOzV23nymxX35o3YcbXyOc5ilZtVoyyWDHEsl5SKhVlvkf/04Ba7AJyXMF3jiWnkLPf
rTxdf/mV3/gKUzDfZ37QOHqnfefeP734w8I9H01TZHHninxseePS+9Wfn2aj+N/o01+hfdGuv/bt
I1+/i7lI5mvuprzLFM4+t2Lt/2qsvcuxPCvPyy9LF8dCG8PDigksiM3f+fkz4/UWLXvxlbmD/3r8
Yx9k9H/2t7/9g1LzmVdWD0TLmRy3jE1ebH3tC9//8n2s2yIqJusUGBdTxx/+3njecRHq+LPjhw79
9KWrWipteee0n/vE2f+qXv/I8/fGaCeEqnEjuS0gktUIU+8QbyfFvV3eFLbyuede+GHzo1f/Mc3K
Szu38j888OIPvvWQ/ZY0RyqNPiY//3HxufuFz/5mGrfqzrmde+l73/rJ/3znhTTS8s5Jv3D61X/f
/swzn2Cm+BRH2t8AOXjw2Gde+b3vH7prkMyuUn7N/uc75KeOTD77jTTxxbj48QgsnTQb92mkpThp
FuQcSmGfkb51rPzj8zVkfOH5NBNTRjWxL40vzf7T+WNqGkFxdJtlbpCNfDZ74k9Ofv/vvv6pz911
5223D1ajEkayXJyY1tp///k3t9/xgas/Sw01pL0KNUh6kEOKMJRzlDQo3jcy8N8e83BP0/w/j+r5
cqbtFEWz9FJK+cztyXD1zdH8x2L5V2n+fXck1/8Shb+V9rRBn1+NxUb3x0bjV1JG532xjZB+ysbI
L8c80of32kPtp/20n/bTftpP+2k/7af9tJ/20376hUr/C79L+64AeAAA
EOF
tar xzf repro.tar.gz
```

Then run:

```bash
clang -O2 -fprofile-instr-use=mut.profdata -c prog_0.c
```


The call site is `call i32 (...) %5()` (zero actual arguments); the profile's hottest
indirect-call target was rewritten to a function with a non-empty fixed
parameter list.

## Output

```text
clang-24: llvm/include/llvm/IR/InstrTypes.h:1362:
Value *llvm::CallBase::getArgOperand(unsigned int) const:
Assertion `i < arg_size() && "Out of bounds!"' failed.
PLEASE submit a bug report to https://github.com/llvm/llvm-project/issues/
Stack dump:
...
#18 llvm::isLegalToPromote(llvm::CallBase const &, llvm::Function *, char const **)
     llvm/lib/Transforms/Utils/CallPromotionUtils.cpp:455
#19 llvm::IndirectCallPromoter::isValidTarget(...)
 llvm/lib/Transforms/Instrumentation/IndirectCallPromotion.cpp:377
#20 llvm::IndirectCallPromoter::getPromotionCandidatesForCallSite(...)
 llvm/lib/Transforms/Instrumentation/IndirectCallPromotion.cpp:441
#23 llvm::PGOIndirectCallPromotion::run(...)
 llvm/lib/Transforms/Instrumentation/IndirectCallPromotion.cpp:1019
```
`llvm-profdata show` accepts the profile.

## Root cause

`llvm/lib/Transforms/Utils/CallPromotionUtils.cpp`:

```cpp
unsigned NumParams = Callee->getFunctionType()->getNumParams();
unsigned NumArgs = CB.arg_size();

if (NumArgs != NumParams && !Callee->isVarArg()) {
  if (FailureReason)
    *FailureReason = "The number of arguments mismatch";
 return false;
}

unsigned I = 0;
for (; I < NumParams; ++I) {
  ...
 Type *ActualTy = CB.getArgOperand(I)->getType();   // OOB when NumParams > NumArgs
  ...
}
```

For a vararg callee, `NumParams > NumArgs` is not rejected, and the loop still runs to
`NumParams`. The profile target is not required to have a compatible signature, so a corrupted
or stale profile can trigger this path.

## Relation to existing work

- #131155: PGO/LTO produces a `musttail` varargs mismatch that is rejected by the verifier
 (`cannot guarantee tail call due to mismatched varargs`). This draft is an ICP arity bug
  that reads a nonexistent call argument in `isLegalToPromote()`, before any verifier check.
- #59269 (closed): ICP on a `musttail` call with mismatched parameter types, also caught by
  the verifier; the mechanism is different (no `getArgOperand` out-of-bounds access).
- #192142 / #192126: ICP target-feature mismatch; different compatibility check and fix.
- #236632: the same `getArgOperand` assertion in `getAllocSize` during InstCombine; unrelated
  code path.
- #230017 / #230018 / #225435: profile reader bounds bugs; different stage.


_______________________________________________
llvm-bugs mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-bugs

Reply via email to