| Issue |
243302
|
| Summary |
[lld][MachO] ld64.lld hits llvm_unreachable("invalid symbol type") on a reserved n_type
|
| Labels |
lld:MachO,
crash
|
| Assignees |
|
| Reporter |
AnantaSrikar
|
`ObjFile::parseNonSectionSymbol` switches on `n_type & N_TYPE` and ends in `llvm_unreachable("invalid symbol type")` for any value it doesn't handle. That value comes from the input, so a symbol with a reserved basic type (here `0x6`, from `n_type` `0x07` or `0x17`) aborts an assertions build. Builds without assertions crash too; Ubuntu LLD 21.1.8 dies with SIGTRAP on the same object.
**Version**: main at c7014922f582 (2026-11-16), built from the Git repository with `-DCMAKE_BUILD_TYPE=Release -DLLVM_ENABLE_ASSERTIONS=ON -DLLVM_ENABLE_PROJECTS=lld`, on x86_64 Linux.
### Reproducer
```sh
cat > ntype.yaml <<'YAML'
--- !mach-o
IsLittleEndian: true
FileHeader:
magic: 0xFEEDFACF
cputype: 0x100000C
cpusubtype: 0x0
filetype: 0x1
ncmds: 2
sizeofcmds: 176
flags: 0x0
reserved: 0x0
LoadCommands:
- cmd: LC_SEGMENT_64
cmdsize: 152
segname: ''
vmaddr: 0
vmsize: 9
fileoff: 208
filesize: 9
maxprot: 7
initprot: 7
nsects: 1
flags: 0
Sections:
- sectname: __text
segname: __TEXT
addr: 0x0
size: 9
offset: 0xD0
align: 2
reloff: 0xE0
nreloc: 1
flags: 0x80000400
reserved1: 0x0
reserved2: 0x0
reserved3: 0x0
content: 00000094C0035FD600
relocations:
- address: 0x0
symbolnum: 1
pcrel: true
length: 2
extern: true
type: 2
scattered: false
value: 0
- cmd: LC_SYMTAB
cmdsize: 24
symoff: 232
nsyms: 2
stroff: 264
strsize: 34
LinkEditData:
NameList:
- n_strx: 1
n_type: 0xF
n_sect: 1
n_desc: 0
n_value: 0
- n_strx: 17
n_type: 0x7
n_sect: 0
n_desc: 0
n_value: 0
StringTable:
- ''
- _entry_00000000
- _target_00000000
...
YAML
yaml2obj ntype.yaml -o ntype.o
ld64.lld -arch arm64 -platform_version macos 11.0 11.0 -dylib -undefined dynamic_lookup -o ntype.dylib ntype.o
```
The second symbol's `n_type` is `0x7`. With `0xF` (an external `N_SECT` symbol) instead, the same object links (status 0). `n_type: 0x17` (the same type with `N_PEXT`) and the same change in an x86-64 object abort the same way.
### Observed
```
invalid symbol type
UNREACHABLE executed at lld/MachO/InputFiles.cpp:852!
```
```
lld::macho::Symbol* lld::macho::ObjFile::parseNonSectionSymbol<lld::structs::nlist_64>(lld::structs::nlist_64 const&, char const*)
void lld::macho::ObjFile::parseSymbols<lld::macho::LP64>(llvm::ArrayRef<lld::macho::LP64::section>, llvm::ArrayRef<lld::macho::LP64::nlist>, char const*, bool)
void lld::macho::ObjFile::parse<lld::macho::LP64>()
lld::macho::ObjFile::ObjFile(llvm::MemoryBufferRef, unsigned int, llvm::StringRef, bool, bool, bool, bool)
```
### Expected
An error naming the symbol and its invalid type.
### Analysis
https://github.com/llvm/llvm-project/blob/c7014922f5829426952a38d079220c21b0a8ebe8/lld/MachO/InputFiles.cpp#L818-L853
The `N_PBUD` case already reports an error and returns `nullptr`. The `default:` case could do the same instead of `llvm_unreachable`. #50156 reached the same `default:` with STABS entries and was fixed by skipping `N_STAB` symbols; reserved basic types still get there.
This report was drafted with help from an AI assistant (Claude); I reviewed it and reproduced it myself.
_______________________________________________
llvm-bugs mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-bugs