Issue 243309
Summary [lld][MachO] ld64.lld indexes the symbol table with an unchecked r_symbolnum from an external relocation
Labels lld:MachO, crash
Assignees
Reporter AnantaSrikar
    For an external relocation, `ObjFile::parseRelocations` does `r.referent = symbols[relInfo.r_symbolnum]` without checking the index. An `r_symbolnum` past the end of the symbol table, or any external relocation in an object without `LC_SYMTAB`, indexes past the end of `symbols`. An assertions build fails libstdc++'s vector bounds check. Without assertions, Ubuntu LLD 21.1.8 links the one-past object with status 0 but drops the relocation's target symbol from the output, and segfaults on the object without `LC_SYMTAB`.

**Version**: main at c7014922f582 (2026-11-16), built from the Git repository with `-DCMAKE_BUILD_TYPE=Release -DLLVM_ENABLE_ASSERTIONS=ON -DLLVM_ENABLE_PROJECTS=lld`, on x86_64 Linux.

### Reproducer

```sh
cat > symnum.yaml <<'YAML'
--- !mach-o
IsLittleEndian:  true
FileHeader:
  magic:           0xFEEDFACF
 cputype:         0x100000C
  cpusubtype:      0x0
  filetype:        0x1
 ncmds:           2
  sizeofcmds:      176
  flags:           0x0
 reserved:        0x0
LoadCommands:
  - cmd:             LC_SEGMENT_64
 cmdsize:         152
    segname:         ''
    vmaddr:          0
 vmsize:          9
    fileoff:         208
    filesize:        9
 maxprot:         7
    initprot:        7
    nsects:          1
 flags:           0
    Sections:
      - sectname:        __text
 segname:         __TEXT
        addr:            0x0
        size: 9
        offset:          0xD0
        align:           2
 reloff:          0xE0
        nreloc:          1
        flags: 0x80000400
        reserved1:       0x0
        reserved2:       0x0
 reserved3:       0x0
        content:         00000094C0035FD600
 relocations:
          - address:         0x0
            symbolnum: 2
            pcrel:           true
            length:          2
 extern:          true
            type:            2
 scattered:       false
            value:           0
  - cmd: LC_SYMTAB
    cmdsize:         24
    symoff:          232
    nsyms: 2
    stroff:          264
    strsize:         34
LinkEditData:
 NameList:
    - n_strx:          1
      n_type:          0xF
 n_sect:          1
      n_desc:          0
      n_value:         0
    - n_strx:          17
      n_type:          0x1
      n_sect:          0
 n_desc:          0
      n_value:         0
  StringTable:
    - ''
 - _entry_00000000
    - _target_00000000
...
YAML
yaml2obj symnum.yaml -o symnum.o
ld64.lld -arch arm64 -platform_version macos 11.0 11.0 -dylib -undefined dynamic_lookup -o symnum.dylib symnum.o
```

The `ARM64_RELOC_BRANCH26` relocation names symbol 2, but there are only two symbols. With `symbolnum: 1` (`_target_00000000`) instead, the same object links (status 0). Removing the `LC_SYMTAB` command and `LinkEditData` (with `ncmds: 1`, `sizeofcmds: 152` and `symbolnum: 1`) fails the same assertion, because `symbols` is then empty.

### Observed

```
libstdc++/bits/stl_vector.h:1263: reference std::vector<lld::macho::Symbol *>::operator[](size_type) [_Tp = lld::macho::Symbol *, _Alloc = std::allocator<lld::macho::Symbol *>]: Assertion '__n < this->size()' failed.
```

```
void lld::macho::ObjFile::parseRelocations<llvm::MachO::section_64>(llvm::ArrayRef<llvm::MachO::section_64>, llvm::MachO::section_64 const&, lld::macho::Section&)
void lld::macho::ObjFile::parseDeferredRelocationsImpl<lld::macho::LP64>()
lld::macho::parseDeferredRelocations()
```

### Expected

An error for the relocation, for example that its symbol index is out of range.

### Analysis

https://github.com/llvm/llvm-project/blob/c7014922f5829426952a38d079220c21b0a8ebe8/lld/MachO/InputFiles.cpp#L629-L631

The `SUBTRACTOR` minuend has the same unchecked access:

https://github.com/llvm/llvm-project/blob/c7014922f5829426952a38d079220c21b0a8ebe8/lld/MachO/InputFiles.cpp#L687-L689

Checking `r_symbolnum < symbols.size()` at both places, and reporting an error for the input file otherwise, would fix it. An object with relocations but without `LC_SYMTAB` then gets the same error.

This report was drafted with help from an AI assistant (Claude); I reviewed it and reproduced it myself.
_______________________________________________
llvm-bugs mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-bugs

Reply via email to