Issue 91090
Summary clang/lib/Sema/SemaExpr.cpp:17213: Pointless test ?
Labels clang, code-quality
Assignees
Reporter dcb314
    Static analyser cppcheck says:

clang/lib/Sema/SemaExpr.cpp:17213:16: style: _expression_ is always true because 'else if' condition is opposite to previous condition at line 17211. [multiCondition]

Source code is

    if (!CheckInferredResultType) {
      ConvHints.tryToFixConversion(SrcExpr, SrcType, DstType, *this);
    } else if (CheckInferredResultType) {

Second if looks pointless to me. Suggest code rework.

_______________________________________________
llvm-bugs mailing list
llvm-bugs@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-bugs

Reply via email to