Issue 97623
Summary llvm/lib/Object/ELF.cpp:415: Poor style ?
Labels mc, llvm
Assignees
Reporter dcb314
    Static analyser cppcheck says:

llvm/lib/Object/ELF.cpp:415:54: style: Clarify calculation precedence for '&' and '?'. [clarifyCalculation]

Source code is

 const size_t FlagBits = Hdr & ELF::CREL_HDR_ADDEND ? 3 : 2;

I think

 const size_t FlagBits = (Hdr & ELF::CREL_HDR_ADDEND) ? 3 : 2;

was probably intended but the code isn't clear.
_______________________________________________
llvm-bugs mailing list
llvm-bugs@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-bugs

Reply via email to