On Thu, 7 Dec 2006, Reid Spencer wrote: > How about cleaning up the rest of it? There are checks to determine > sanity all for the purpose of producing the message you deleted.
I think that makes a lot of sense, but I don't really feel confident removing the rest (inexperience with configure). In particular, we currently still need LLVMGCC_VERSION/LLVMGCC_MAJVERS to be computed which depends on sanity, no? I think it makes sense for llvm to still detect llvm-gcc (for use with llvm/test and llvm-test) but not require it. -Chris > On Thu, 2006-12-07 at 23:04 -0600, Chris Lattner wrote: >> >> Changes in directory llvm/autoconf: >> >> configure.ac updated: 1.253 -> 1.254 >> --- >> Log message: >> >> this warning is obsolete with llvmgcc3 being gone >> >> >> --- >> Diffs of the changes: (+0 -8) >> >> configure.ac | 8 -------- >> 1 files changed, 8 deletions(-) >> >> >> Index: llvm/autoconf/configure.ac >> diff -u llvm/autoconf/configure.ac:1.253 llvm/autoconf/configure.ac:1.254 >> --- llvm/autoconf/configure.ac:1.253 Thu Nov 30 18:37:14 2006 >> +++ llvm/autoconf/configure.ac Thu Dec 7 23:03:54 2006 >> @@ -834,11 +834,3 @@ >> dnl Finally, crank out the output >> AC_OUTPUT >> >> -dnl Warn loudly if llvm-gcc was not obviously working >> -if test "$llvm_cv_llvmgcc_sanity" = "no" ; then >> - AC_MSG_WARN([***** llvm-gcc/llvm-g++ was not found, or does not appear to >> be ]) >> - AC_MSG_WARN([***** working. Please make sure you have llvm-gcc and >> llvm-g++ in]) >> - AC_MSG_WARN([***** your path before configuring LLVM. The runtime >> libraries]) >> - AC_MSG_WARN([***** (llvm/runtime) will not be built but you should be able >> to]) >> - AC_MSG_WARN([***** build the llvm tools.]) >> -fi >> >> >> >> _______________________________________________ >> llvm-commits mailing list >> llvm-commits@cs.uiuc.edu >> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits > -Chris -- http://nondot.org/sabre/ http://llvm.org/ _______________________________________________ llvm-commits mailing list llvm-commits@cs.uiuc.edu http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits