Chris, Yes, this looks fine.
On Thu, 2007-01-04 at 12:46 -0600, Chris Lattner wrote: > > Changes in directory llvm/tools/llvm-upgrade: > > UpgradeParser.y updated: 1.31 -> 1.32 > --- > Log message: > > If we hit a parse error, emit something bad to the output stream. This > ensures that > llvm-upgrade < foo | llvm-as | llvm-dis > > will fail if llvm-upgrade fails. > > > > --- > Diffs of the changes: (+2 -0) > > UpgradeParser.y | 2 ++ > 1 files changed, 2 insertions(+) > > > Index: llvm/tools/llvm-upgrade/UpgradeParser.y > diff -u llvm/tools/llvm-upgrade/UpgradeParser.y:1.31 > llvm/tools/llvm-upgrade/UpgradeParser.y:1.32 > --- llvm/tools/llvm-upgrade/UpgradeParser.y:1.31 Wed Jan 3 17:43:55 2007 > +++ llvm/tools/llvm-upgrade/UpgradeParser.y Thu Jan 4 12:45:51 2007 > @@ -72,6 +72,7 @@ > > if (yyparse()) { > std::cerr << "Parse failed.\n"; > + out << "llvm-upgrade parse failed.\n"; > exit(1); > } > } > @@ -1597,5 +1598,6 @@ > else > errMsg += "token: '" + std::string(Upgradetext, Upgradeleng) + "'"; > std::cerr << "llvm-upgrade: " << errMsg << '\n'; > + *O << "llvm-upgrade parse failed.\n"; > exit(1); > } > > > > _______________________________________________ > llvm-commits mailing list > llvm-commits@cs.uiuc.edu > http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits _______________________________________________ llvm-commits mailing list llvm-commits@cs.uiuc.edu http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits