Nice work Anton, some comments below: > @@ -1082,7 +1081,11 @@ > <td class="td_left">If this bit is set, a SectionID follows > this vbr.</td> > </tr> > <tr> > - <td><a href="#bit">bit(10-31)</a></td> > + <td><a href="#bit">bit(10-12)</a></td> > + <td class="td_left">Visibility style: 0=Default, 1=Hidden.</td> > + </tr> > + <tr> > + <td><a href="#bit">bit(13-31)</a></td> > <td class="td_left">Currently unassigned.</td> > </tr> > </tbody>
Why reserve 3 bits for visibility? > +<!-- > ______________________________________________________________________ > _ --> > +<div class="doc_subsubsection"><a > name="funclinkage_and_visibility">Linkage and > + visibility word</a> > +</div> > +<div class="doc_text"> > + > +<table> > + <tbody> > + <tr> > + <th><b>Type</b></th> > + <th class="td_left"><b>Field Description</b></th> > + </tr> > + <tr> > + <td><a href="#bit">bit(0-15)</a></td> > + <td class="td_left">The linkage type of the function: > 0=External, 1=Weak, > +2=Appending, 3=Internal, 4=LinkOnce, 5=DllImport, > 6=DllExport<sup>1</sup></td> > + </tr> > + <tr> > + <td><a href="#bit">bit(16-31)</a></td> > + <td class="td_left">Visibility style: 0=Default, 1=Hidden.</td> Why reserve 16 bits for visibility? :) Also, please add some info to LangRef.html about visibility. Thanks! -Chris _______________________________________________ llvm-commits mailing list llvm-commits@cs.uiuc.edu http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits