> +++ llvm/lib/CodeGen/SelectionDAG/LegalizeDAG.cpp Sun Jan 28
> 07:31:35 2007
> @@ -2168,6 +2168,7 @@
> const char *FnName = 0;
> if (Node->getOpcode() == ISD::MEMSET) {
> Entry.Node = Tmp2; Entry.isSigned = false; Entry.Ty =
> IntPtrTy;
> + Entry.isInReg = false;
Please remove the tabs here and elsewhere.
> // Add one result value for each formal argument.
> std::vector<MVT::ValueType> RetVals;
> + unsigned j = 0;
> for (Function::arg_iterator I = F.arg_begin(), E = F.arg_end();
> I != E; ++I) {
> MVT::ValueType VT = getValueType(I->getType());
> + bool isInReg = FTy->paramHasAttr(++j,
> FunctionType::InRegAttribute);
Please increment j in the for loop, e.g. "++I, ++j" to make it more
clear how j is evolving.
Overall, this is a great patch, nice work!
-Chris
_______________________________________________
llvm-commits mailing list
llvm-commits@cs.uiuc.edu
http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
