On Mar 24, 2007, at 8:34 AM, Zhou Sheng wrote: > > > Changes in directory llvm/lib/Transforms/Scalar: > > InstructionCombining.cpp updated: 1.682 -> 1.683 > --- > Log message: > > Make some codes more efficient. > > @@ -5813,7 +5816,6 @@ > case 16 : SExtType = Type::Int16Ty; break; > case 32 : SExtType = Type::Int32Ty; break; > case 64 : SExtType = Type::Int64Ty; break; > - case 128: SExtType = IntegerType::get(128); break; > default: break; > } > if (SExtType) {
why did you remove this? > @@ -5833,7 +5835,7 @@ > BinaryOperator::createShl(X, ConstantInt::get(Ty, > ShiftDiff)); > InsertNewInstBefore(Shift, I); > > - APInt Mask(APInt::getAllOnesValue(TypeBits).shl(ShiftAmt2)); > + APInt Mask(Ty->getMask().shl(ShiftAmt2)); You touched many instances of this. Please make a new APInt::getHighBits method. -Chris _______________________________________________ llvm-commits mailing list llvm-commits@cs.uiuc.edu http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits