>> Hrm? Why a subdirectory? > > Three reasons: > 1. Many of the tests are similar but just modified for APInt. So > instead > of having > sext-apint.ll and zext-apint.ll and or-apint.ll, etc., I just > factored the name > out into a directory. Also reduces clutter in the > test/Transforms/InstCombine > directory.
the is no logical difference between apint tests and non-apint tests for instcombine. If you want to include apint in the filename, that's fine, but I don't think a directory is useful. > 2. To allow "make check TESTSUITE=test/Transforms/InstCombine/ > APInt" to > just check > the APInt versions of these tests. This is a temporary convenience while you're working on apint'ifying instcombine. This will not be useful once you're done. -Chris _______________________________________________ llvm-commits mailing list llvm-commits@cs.uiuc.edu http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
