On Mon, 2007-04-09 at 17:03 -0700, Jeff Cohen wrote: > Reid Spencer wrote: > > On Mon, 2007-04-09 at 18:40 -0500, Devang Patel wrote: > > > > > Changes in directory llvm/test/Transforms/LoopRotate: > > > > > > PhiRename-1.ll updated: 1.1 -> 1.2 > > > --- > > > Log message: > > > > > > Add check for opt crash. > > > > > > > This idiom is becoming more and more prevalent. While it works, its also > > doubling the runtime of each test its used in. I'm wondering if we could > > invest in a "notgrep" script (since we're invoking "not" anyway) that > > would fail on empty input. Is this sufficient to avoid having to do > > things twice? > > It won't work. The command can crash after producing some output, but > still not producing a line being grepped for.
Okay, I wasn't so much suggesting that as the ultimate solution but wondering more if the problem is one we should/can fix. Perhaps dejagnu can interpret/watch the pipeline or something and check exit statuses of each component to ensure they all return 0, not just the last one. I'll file this as a "fix someday nice to have" Reid. _______________________________________________ llvm-commits mailing list llvm-commits@cs.uiuc.edu http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits